Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM Data plugin asset installation feedback loop #14811

Open
lucabelluccini opened this issue Dec 4, 2024 · 3 comments
Open

APM Data plugin asset installation feedback loop #14811

lucabelluccini opened this issue Dec 4, 2024 · 3 comments

Comments

@lucabelluccini
Copy link
Contributor

lucabelluccini commented Dec 4, 2024

After 8.15.0, the APM assets are installed by the apm-data plugin in ES.
In case an error occurs, we've observed:

  • Elasticsearch logs errors (good) as below
  • It seems it retries continuously to install the assets (good, but maybe it should retry periodically?)
[instance-0000000054] error adding index template [traces-apm@template] for [apm] java.lang.IllegalArgumentException: composable template [traces-apm@template] template after composition with component templates [traces@mappings, apm@mappings, apm@settings, apm-10d@lifecycle, traces-apm@mappings, traces-apm-fallback@lifecycle, traces@custom, traces-apm@custom, ecs@mappings] is invalid at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService.validateIndexTemplateV2(MetadataIndexTemplateService.java:753) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService.addIndexTemplateV2(MetadataIndexTemplateService.java:640) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService.addIndexTemplateV2(MetadataIndexTemplateService.java:587) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService$5.execute(MetadataIndexTemplateService.java:532) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService$1.executeTask(MetadataIndexTemplateService.java:149) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.metadata.MetadataIndexTemplateService$1.executeTask(MetadataIndexTemplateService.java:146) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.SimpleBatchedExecutor.execute(SimpleBatchedExecutor.java:70) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.service.MasterService.innerExecuteTasks(MasterService.java:1070) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:1033) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.service.MasterService.executeAndPublishBatch(MasterService.java:233) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.service.MasterService$BatchingTaskQueue$Processor.lambda$run$2(MasterService.java:1686) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.action.ActionListener.run(ActionListener.java:444) ~[elasticsearch-8.15.5.jar:?] at org.elasticsearch.cluster.service.MasterService$BatchingTaskQueue$Processor.run(MasterService.java:1683) ~[elasti

In this particular case, it was due to the presence of a conflicting mapping between traces-apm@custom (by the user) and traces-apm@mappings (our, which changed between 8.12 and 8.15)

But the user has no feedback except if they are looking at the logs...
We should find a way to "expose this" to Kibana.

Other comments:

  • Each APM data stream is handled singularly, so some assets installations might succeed, others might fail (e.g. traces-apm@template might be successful, but traces-apm.rum@template might fail)
  • No way for users to "test" the setup prior installing the assets

Failure to install assets can generate data loss, so it's not something which can be left unaddressed.

FYI @simitt (not urgent but raised to keep track of it)

@simitt
Copy link
Contributor

simitt commented Dec 5, 2024

@mlunadia for awareness - we would need to collaborate with the UI team for bringing feedback to the customers. Happy to provide more context where needed, but would appreciate your input here.

@mlunadia
Copy link

mlunadia commented Dec 5, 2024

@simitt which UI team specifically? can we raise an issue in their repo describing the solution we are suggesting to surface these errors?

@simitt
Copy link
Contributor

simitt commented Dec 6, 2024

@mlunadia I don't think we have a mapped out solution, hence also not 100% clear which UI team. I am not aware that the Fleet managed apm setup offered a UI for seeing mapping conflicts (which could also happen then, this is not a problem introduced with the switch to apm ES plugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants