Port to Linux

[elasota]

Port to Linux. This may be fairly straightforward since there's already a working Cygwin version.

[ghost]

I'll check out this issue this weekend to see if I can contribute. I'll let you know how it goes. Thank you so much for making this port!

[elasota]

Okay, probably good start would be just do "cmake ." + "make install" and see if it works with the 1.1.0 pre-release 1 data. It's already working with Cygwin, so there's a chance that's all it needs.

[ghost]

I've been checking the project, reading the code and getting used to it's organization. It compiles with very minor changes on Ubuntu 18.04, but it crashes when attempting to link the GLSL shaders. I'll keep you posted when I find out what's the issue.

[voltagex]

@miky-kr5 are you able to push what you've done to a branch?

[HolographicDoll]

Okay, I did an out-of-the-box "git clone" + "cmake ." + "make install" on Ubuntu 22.04.

Here's what I got:

~/Downloads/Aerofoil/AerofoilX/GpSystemServices_X.cpp: In member function 'virtual void* GpSystemServices_X::CreateThread(IGpSystemServices::ThreadFunc_t, void*)':  
~/Downloads/Aerofoil/AerofoilX/GpSystemServices_X.cpp:60:28: error: cannot convert 'std::nullptr_t' to 'pthread_t' {aka 'long unsigned int'} in initialization  
   60 |         pthread_t thread = nullptr;  
      |                            ^~~~~~~  
~/Downloads/Aerofoil/AerofoilX/GpSystemServices_X.cpp:70:16: error: invalid conversion from 'pthread_t' {aka 'long unsigned int'} to 'void*' [-fpermissive]  
   70 |         return thread;  
      |                ^~~~~~  
      |                |  
      |                pthread_t {aka long unsigned int}  
make[2]: *** [CMakeFiles/AerofoilX.dir/build.make:258: CMakeFiles/AerofoilX.dir/AerofoilX/GpSystemServices_X.cpp.o] Error 1  
make[1]: *** [CMakeFiles/Makefile2:261: CMakeFiles/AerofoilX.dir/all] Error 2  
make: *** [Makefile:136: all] Error 2

[ghost]

Any news on this?

[elasota]

I've pushed a change that should hopefully fix the pthread_t problem

[HolographicDoll]

Attempted to compile just now with the change. pthread_t is fixed, but I got new errors:

~/Aerofoil/AerofoilX/GpFileSystem_X.cpp:113:16: error: ‘fseek64’ was not declared in this scope; did you mean ‘lseek64’?
  113 |         return fseek64(m_f, static_cast<off64_t>(loc), SEEK_SET) >= 0;
      |                ^~~~~~~
      |                lseek64
~/Aerofoil/AerofoilX/GpFileSystem_X.cpp: In member function ‘virtual bool GpFileStream_X_File::SeekCurrent(GpFilePos_t)’:
~/Aerofoil/AerofoilX/GpFileSystem_X.cpp:122:16: error: ‘fseek64’ was not declared in this scope; did you mean ‘lseek64’?
  122 |         return fseek64(m_f, static_cast<off64_t>(loc), SEEK_CUR) >= 0;
      |                ^~~~~~~
      |                lseek64
~/Aerofoil/AerofoilX/GpFileSystem_X.cpp: In member function ‘virtual bool GpFileStream_X_File::SeekEnd(GpUFilePos_t)’:
~/Aerofoil/AerofoilX/GpFileSystem_X.cpp:131:16: error: ‘fseek64’ was not declared in this scope; did you mean ‘lseek64’?
  131 |         return fseek64(m_f, -static_cast<off64_t>(loc), SEEK_END) >= 0;
        |                ^~~~~~~
        |                lseek64
make[2]: *** [CMakeFiles/AerofoilX.dir/build.make:272: CMakeFiles/AerofoilX.dir/AerofoilX/GpFileSystem_X.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:261: CMakeFiles/AerofoilX.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Looks like there just needs to be a || (__linux__) added to the if on line 30, however, if I do that and try again, I get:

/usr/bin/ld: cannot open output file AerofoilX: Is a directory
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/AerofoilX.dir/build.make:327: AerofoilX] Error 1
make[1]: *** [CMakeFiles/Makefile2:261: CMakeFiles/AerofoilX.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

[fpiesche]

Just so you know, I put together a Flatpak build for Aerofoil on Linux a while ago and have just made that build work again (after the CMake changes above broke it)! If you'd be okay with this I'd love to fix this up to work fully and submit it to Flathub for distribution - I'll pop my head back in with a link to a downloadable .flatpak bundle to test out if you'd like to see how that works :)

[elasota]

That sounds fine, if you have a PR for it then I can take a look.

However, since I don't have the means to test or troubleshoot Linux builds myself, I would just ask that if you're going to distribute it on Flathub, please include some kind of notification (e.g. a readme, or whatever else is appropriate) that you're the maintainer of that distribution.