diff --git a/.rubocop.yml b/.rubocop.yml index 2c3b757..1fda459 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,4 +1,4 @@ -# Rubocop, we're buddies and all, but we're going to have to disagree on the following - +# Rubocop, we're buddies and all, but we're going to have to disagree on the following - # Allow compact class definitions Style/ClassAndModuleChildren: @@ -97,3 +97,11 @@ Style/SpaceBeforeFirstArg: AllCops: Include: - '**/*.rb' + +# allow longer blocks +Metrics/BlockLength: + Max: 50 + +# allow longer argument lists +Metrics/ParameterLists: + Max: 6 diff --git a/bin/aws_cleaner.rb b/bin/aws_cleaner.rb index 9bdaed6..962695c 100755 --- a/bin/aws_cleaner.rb +++ b/bin/aws_cleaner.rb @@ -69,7 +69,7 @@ def config(file) if @instance_id if @config[:webhooks] @config[:webhooks].each do |hook, hook_config| - if AwsCleaner::Webhooks::fire_webhook(hook_config, @config, @instance_id) + if AwsCleaner::Webhooks.fire_webhook(hook_config, @config, @instance_id) puts "Successfully ran webhook #{hook}" else puts "Failed to run webhook #{hook}" diff --git a/lib/aws_cleaner/aws_cleaner.rb b/lib/aws_cleaner/aws_cleaner.rb index dff5f38..a554671 100644 --- a/lib/aws_cleaner/aws_cleaner.rb +++ b/lib/aws_cleaner/aws_cleaner.rb @@ -142,7 +142,7 @@ def self.notify_chat(msg, config) module Webhooks # generate the URL for the webhook - def self.generate_template(item, template_variable_method, template_variable_argument, template_variable, config, instance_id) + def self.generate_template(item, template_variable_method, _template_variable_argument, template_variable, config, instance_id) if template_variable_method == 'get_chef_fqdn' replacement = AwsCleaner::Chef.get_chef_fqdn(instance_id, config) elsif template_variable_method == 'get_chef_node_name'