Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Adapt workflow example to be based on real source model #1183

Open
tortmayr opened this issue Nov 30, 2023 · 1 comment
Open

Proposal: Adapt workflow example to be based on real source model #1183

tortmayr opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tortmayr
Copy link
Contributor

Currently the workflow example is based on the direct-gmodel library. While gmodel only is nice
for quick prototyping and PoC creation most of the diagram languages implemented by our adopters are
based on an actual underlying source model (for instance json or and EMF).
Since the workflow example is gmodel-only we basically never full test the API capabilities in development and a lot of bugs
remain undiscovered until reported by an adopter that uses a different source model
(e.g. #1168)
IMO it would be better in the longrun if we adapt the workflow example to be based on an JSON source model. This way we have more
confidence that new API and features work as intend for a majority of adopters.

We could also use this opportunity to introduce a second diagram language a long side the workflow example that is GModel only.
This could be a read-only language that is just used to read and render GModel source models.
This way we could tackle multiple issues at once.

@tortmayr tortmayr added the enhancement New feature or request label Nov 30, 2023
@planger
Copy link
Member

planger commented Nov 30, 2023

I agree, this would help identifying potential flaws in new features earlier, also with respect to upcoming end-to-end tests.
However, the read-only use case I feel is not as important to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants