Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Tomcat with Jetty in WarRunner #979

Closed
2 tasks
Tracked by #968
earldouglas opened this issue Oct 14, 2024 · 1 comment
Closed
2 tasks
Tracked by #968

Replace Tomcat with Jetty in WarRunner #979

earldouglas opened this issue Oct 14, 2024 · 1 comment
Assignees
Milestone

Comments

@earldouglas
Copy link
Owner

earldouglas commented Oct 14, 2024

Let's see if we can replace Tomcat with Jetty.

  • Swap out com.heroku:webapp-runner for org.eclipse.jetty.ee10:jetty-ee10-webapp
  • Launch Jetty via org.eclipse.jetty.ee10.runner.Runner

This will mostly be a drop-in replacement for WarPackageRunnerPlugin, but WebappComponentsRunnerPlugin is going to need its own version of com.earldouglas:webapp-components-runner.

For context, see scalatra/scalatra.g8#131 (comment)

See also:

@earldouglas earldouglas self-assigned this Oct 14, 2024
@earldouglas earldouglas added this to the 5.0.0 milestone Oct 18, 2024
@earldouglas earldouglas changed the title Experiment with Jetty in place of Tomcat Replace Tomcat with Jetty in war-runner Nov 16, 2024
earldouglas added a commit that referenced this issue Nov 16, 2024
@earldouglas earldouglas changed the title Replace Tomcat with Jetty in war-runner Replace Tomcat with Jetty in WarRunner Nov 16, 2024
earldouglas added a commit that referenced this issue Nov 16, 2024
earldouglas added a commit that referenced this issue Nov 16, 2024
earldouglas added a commit that referenced this issue Nov 16, 2024
earldouglas added a commit that referenced this issue Nov 16, 2024
@earldouglas
Copy link
Owner Author

I can't get Jetty to scan for annotations, no matter what I try. Closing this as a wontfix.

@earldouglas earldouglas closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant