Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce calls to getenv #28

Open
Ethane98 opened this issue Mar 23, 2022 · 0 comments
Open

Reduce calls to getenv #28

Ethane98 opened this issue Mar 23, 2022 · 0 comments
Labels
future improvement Issues that have a work around right now, but can be better solved in the future

Comments

@Ethane98
Copy link
Contributor

SPI currently calls getenv() repeatedly during instrumentation instead of storing variables at start.

Additionally, getenv("X") should be replaced with getenv_bool("X"), defined as not (undefined v || v is "" || v is "0" || v is "false"). This checks for environment variable values instead of just definition, making configuration more user-friendly.
@Ethane98 Ethane98 added the future improvement Issues that have a work around right now, but can be better solved in the future label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future improvement Issues that have a work around right now, but can be better solved in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ethane98