Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: Introduce lock check for some functions #424

Open
Y-- opened this issue Nov 12, 2024 · 1 comment
Open

[chore]: Introduce lock check for some functions #424

Y-- opened this issue Nov 12, 2024 · 1 comment
Labels
developer experience Improves our own lives

Comments

@Y--
Copy link
Collaborator

Y-- commented Nov 12, 2024

Description

Following this comment https://github.com/duckdb/pg_duckdb/pull/415/files#r1837875339 we want to introduce a way to ensure certain non-thread safe functions are indeed called under a lock.
@JelteF
Copy link
Collaborator

JelteF commented Nov 12, 2024

Another option is to introduce re-entrant (aka recursive) lock and actually take the lock in those functions.

@JelteF JelteF added the developer experience Improves our own lives label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer experience Improves our own lives
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Y-- @JelteF