Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor portability issue: tar may not accept xJf flags: tar: invalid option -- J #627

Open
barracuda156 opened this issue Dec 5, 2024 · 2 comments

Comments

@barracuda156
Copy link

@krlmlr This 9375cfa is not really portable, from what it looks:

--->  Building R-duckdb
xinstall: mkdir /opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_R_R-duckdb/R-duckdb/work/build
Executing:  cd "/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_R_R-duckdb/R-duckdb/work/duckdb" && /opt/local/bin/R CMD INSTALL . --library=/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_R_R-duckdb/R-duckdb/work/build --install-tests 
* installing *source* package ‘duckdb’ ...
file ‘src/Makevars’ has the wrong MD5 checksum
** using staged installation
++ dirname ./configure
+ cd ./src
+ '[' -f '' ']'
+ cp include/to-tar.mk Makevars.duckdb
+ '[' -f duckdb.tar.xz ']'
+ tar xJf duckdb.tar.xz
tar: invalid option -- J
Try `tar --help' or `tar --usage' for more information.
ERROR: configuration failed for package ‘duckdb’

This is not a big deal, since patching this to use specifically gnutar fixes the issue, but perhaps worth at least either having a check or a note in README?

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 5, 2024

Thanks. I'll consider that if this is a widespread problem; recent tar on macOS and Linux seem to support this. For now, this issue might be documentation enough?

@barracuda156
Copy link
Author

@krlmlr Yes, I think that is sufficient, perhaps. There should be no problem to build a modern gnutar on any platform, so in the worst case it is a matter of an extra dependency.

I added this now: https://github.com/macports/macports-ports/blob/d6c3003256410b8978c14c0a919c391dd3b2b307/R/R-duckdb/Portfile#L22-L26
(Easier just to depend on it that determine exact OS versions where that option is supported or not.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants