-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use RE2 on CRAN #121
Comments
Does rhub2 catch this? Run: https://github.com/duckdb/duckdb-r/actions/runs/8402600629 |
Yes, rhub2 catches this. I've also created a PR that breaks @hannes @Tmonster: There are at least two scenarios where re2 is invoked (involuntarily) -- listing tables and exporting the database, perhaps the latter is a variant of the former. I could work around for CRAN, but this will also show if other packages call To reproduce, install the R package from #125. library(duckdb)
#> Loading required package: DBI
con <- dbConnect(duckdb())
dbGetQuery(con, "SELECT * FROM sqlite_master")
#> Error: {"exception_type":"Invalid Input","exception_message":"Attempting to execute an unsuccessful or closed pending query result\nError: Invalid Error: Checking without re2 support"}
dbGetQuery(con, "SELECT * FROM information_schema.tables")
#> Error: {"exception_type":"Invalid Input","exception_message":"Attempting to execute an unsuccessful or closed pending query result\nError: Invalid Error: Checking without re2 support"}
dbGetQuery(con, "SELECT * FROM duckdb_tables()")
#> Error: {"exception_type":"Invalid Input","exception_message":"Attempting to execute an unsuccessful or closed pending query result\nError: Invalid Error: Checking without re2 support"} Created on 2024-03-24 with reprex v2.1.0 export_location <- tempfile("duckdb_test_export")
dir.create(export_location)
con <- DBI::dbConnect(duckdb::duckdb())
DBI::dbExecute(con, "CREATE TABLE integers(i integer)")
#> [1] 0
DBI::dbExecute(con, "insert into integers select * from range(10)")
#> [1] 10
DBI::dbExecute(con, "CREATE TABLE integers2(i INTEGER)")
#> [1] 0
DBI::dbExecute(con, "INSERT INTO integers2 VALUES (1), (5), (7), (1928)")
#> [1] 4
DBI::dbExecute(con, paste0("EXPORT DATABASE '", export_location, "'"))
#> Error: rapi_prepare: Failed to prepare query EXPORT DATABASE '/var/folders/dj/yhk9rkx97wn_ykqtnmk18xvc0000gn/T//Rtmp5kUEV2/duckdb_test_export141f23e55a3c7'
#> Error: Invalid Error: Checking without re2 support Created on 2024-03-24 with reprex v2.1.0 |
On the other hand, there are only two downstream packages that have compiled code: arrow and another one, none of them shows the failing checks now. We can submit, but this is a time bomb worth fixing eventually. |
This may be fixed by duckdb/duckdb#11252 from the next version 0.10.2 |
Add a check here to check it's not used.
The text was updated successfully, but these errors were encountered: