Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Importers - Destination Full Support #1424

Open
calumcalder opened this issue Jan 16, 2025 · 0 comments
Open

Generic Importers - Destination Full Support #1424

calumcalder opened this issue Jan 16, 2025 · 0 comments

Comments

@calumcalder
Copy link
Collaborator

Background

Importers can signal failure for specific reasons with various subclasses of CopyExceptionWithFailureReason, some of which are treated as restartable errors. For example, InvalidTokenException and DestinationMemoryFullException signal a token expiry (which requires reauth and a restart) and a full destination (which requires the user to create space and restart) respectively.

Generic Importers (added in #1389) supports throwing InvalidTokenException on a 401 response with an invalid_token error from the API, but does not support DestinationMemoryFullException.

Proposal

To support destinations using Generic Importers creating a DestinationMemoryFullException, the API could be extended to define another error code and error name combination - e.g. 400 and destination_full. The Generic Importers code would then need to be extended to support handling this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant