Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: missing test coverage for newer video logic in MediaContainerResource #1060

Open
1 task
jzacsh opened this issue Apr 15, 2022 · 1 comment
Open
1 task

bug: missing test coverage for newer video logic in MediaContainerResource #1060

jzacsh opened this issue Apr 15, 2022 · 1 comment

Comments

@jzacsh
Copy link
Collaborator

jzacsh commented Apr 15, 2022 •
edited
Loading

see #1058 for context

task:

  • add new test coverage for the video logic in MediaContainerResource
@jzacsh jzacsh mentioned this issue Apr 15, 2022
Closed
5 tasks
@jzacsh jzacsh changed the title add new test coverage for the forked code (the fork's purpose is to introduce video handling; my first step is just porting over the existing original test code, so this isn't fixed by my work yet) add new test coverage for the video logic in MediaContainerResource Apr 15, 2022
@jzacsh jzacsh changed the title add new test coverage for the video logic in MediaContainerResource bug: missing test coverage for newer video logic in MediaContainerResource Apr 15, 2022
@jzacsh jzacsh mentioned this issue Apr 16, 2022
Merged
jzacsh added a commit that referenced this issue Apr 18, 2022
@jzacsh
fixes #1058: add MediaContainerResourceTest & more (#1059)
90708fe 
backfills missing unit tests of MedaiContainerResourceTest and fixes a bug in the process

This change forks test code (`{Photos,Media}ContainerResourceTest`) in line with MediaContainerResource's existing creation, then deletes some transmogrification stuff that we're not doing (per issue #1000) and adds a TODO(#1060) atop the new test to finish the tests more fully for video logic.
@Higgs32584
Copy link

is this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzacsh @Higgs32584