Fix the Syndication Feed RFC822 DateTimeParser #99194
Conversation
RFC822 allows single-digit date values and two-digit year values in the publication date (pubDate). The existing date-time parser only accepted two-digit dates and (for some formats) four-digit years.
| "d MMMM yyyy HH:mm:ss zzz", | ||
| "ddd, d MMM yyyy HH:mm:ss zzz", | ||
| "d MMM yyyy HH:mm:ss zzz", | ||
|
|
| "ddd, dd MMMM yyyy HH:mm zzz", | ||
| "dd MMMM yyyy HH:mm zzz", | ||
| "ddd, dd MMM yyyy HH:mm zzz", | ||
| "dd MMM yyyy HH:mm zzz", |
There was a problem hiding this comment.
This is removing the overloads without the :ss part, why? (seconds are optional in the time-of-day ABNF in RFC 5322)
There was a problem hiding this comment.
I'm not sure what you mean; I didn't remove any overloads or change the :ss part. All the previously existing formats are still there, just with the correct number of digits for date and year.
There was a problem hiding this comment.
Ah, sorry, it was hidden under the messages about whitespace error.
There was a problem hiding this comment.
Oh, that makes sense, there were a LOT of error messages! 😅
|
Any chance on getting this merged for .NET 9? |
|
Any chance of getting this merged for 9.0.2? This is very simple fix for a bug caused by a small typo. There is almost zero risk to merging this, and it would fix a bug that has existed in my application for a year now. |
RFC822 allows single-digit date values and two-digit year values in the publication date (
pubDate). The existingRfc822DateTimeParsermethod inSystem.ServiceModel.Syndication.DateTimeHelperonly accepts two-digit dates and (for some formats) four-digit years.This PR updates the list of date-time formats.
Fixes #99193