Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Interop.SourceGeneration gets built twice (with a potential of a race) #111654

Open
ViktorHofer opened this issue Jan 21, 2025 · 1 comment
Labels
area-System.Runtime.InteropServices tenet-build-performance Impacts build time: official, developer or CI
Milestone

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 21, 2025

  installer.tasks -> C:\git\runtime4\artifacts\bin\installer.tasks\Debug\net10.0\installer.tasks.dll
  Crossgen2Tasks -> C:\git\runtime4\artifacts\bin\Crossgen2Tasks\Debug\net10.0\Crossgen2Tasks.dll
  Microsoft.Interop.SourceGeneration -> C:\git\runtime4\artifacts\bin\Microsoft.Interop.SourceGeneration\Debug\netstandard2.0\Microsoft.Interop.SourceGeneration.dll
  DownlevelLibraryImportGenerator -> C:\git\runtime4\artifacts\bin\DownlevelLibraryImportGenerator\Debug\netstandard2.0\Microsoft.Interop.LibraryImportGenerator.Downle
  vel.dll
  installer.tasks -> C:\git\runtime4\artifacts\bin\installer.tasks\Debug\net472\installer.tasks.dll
  ILLink.RoslynAnalyzer -> C:\git\runtime4\artifacts\bin\ILLink.RoslynAnalyzer\Debug\netstandard2.0\ILLink.RoslynAnalyzer.dll
  ILLink.CodeFixProvider -> C:\git\runtime4\artifacts\bin\ILLink.CodeFixProvider\Debug\netstandard2.0\ILLink.CodeFixProvider.dll
  Mono.Linker -> C:\git\runtime4\artifacts\bin\Mono.Linker\ref\Debug\net10.0\illink.dll
  Mono.Linker -> C:\git\runtime4\artifacts\bin\Mono.Linker\Debug\net10.0\illink.dll
  ILLink.Tasks -> C:\git\runtime4\artifacts\bin\ILLink.Tasks\Debug\net\ILLink.Tasks.dll
  System.Private.CoreLib.Generators -> C:\git\runtime4\artifacts\bin\System.Private.CoreLib.Generators\Debug\netstandard2.0\System.Private.CoreLib.Generators.dll
  System.Private.CoreLib -> C:\git\runtime4\artifacts\bin\System.Private.CoreLib\ref\Debug\net10.0\System.Private.CoreLib.dll
  Microsoft.Interop.SourceGeneration -> C:\git\runtime4\artifacts\bin\Microsoft.Interop.SourceGeneration\Debug\netstandard2.0\Microsoft.Interop.SourceGeneration.dll
  LibraryImportGenerator -> C:\git\runtime4\artifacts\bin\LibraryImportGenerator\Debug\netstandard2.0\Microsoft.Interop.LibraryImportGenerator.dll

and the build then later yet again builds the DownlevelLibraryImportGenerator project:

  BUILD: Product binaries are available at C:\git\runtime4\artifacts\bin\coreclr\linux.x64.Debug\x64
  runincontext -> C:\git\runtime4\artifacts\bin\coreclr\windows.x64.Debug\runincontext.dll
  tieringtest -> C:\git\runtime4\artifacts\bin\coreclr\windows.x64.Debug\tieringtest.dll
  DownlevelLibraryImportGenerator -> C:\git\runtime4\artifacts\bin\DownlevelLibraryImportGenerator\Debug\netstandard2.0\Microsoft.Interop.LibraryImportGenerator.Downle
  vel.dll
  ILCompiler.TypeSystem -> C:\git\runtime4\artifacts\bin\ILCompiler.TypeSystem\x64\Debug\ILCompiler.TypeSystem.dll

cc @jkoritzinsky

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 21, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@AaronRobinsonMSFT AaronRobinsonMSFT added tenet-build-performance Impacts build time: official, developer or CI and removed untriaged New issue has not been triaged by the area owner labels Jan 21, 2025
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 10.0.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime.InteropServices tenet-build-performance Impacts build time: official, developer or CI
Projects
Status: No status
Development

No branches or pull requests

2 participants