diff --git a/src/NetAnalyzers/Core/AnalyzerReleases.Shipped.md b/src/NetAnalyzers/Core/AnalyzerReleases.Shipped.md index 377a93dd3a..9aa1105442 100644 --- a/src/NetAnalyzers/Core/AnalyzerReleases.Shipped.md +++ b/src/NetAnalyzers/Core/AnalyzerReleases.Shipped.md @@ -53,21 +53,16 @@ CA1068 | Design | Info | CancellationTokenParametersMustComeLastAnalyzer, [Docum CA1069 | Design | Info | EnumShouldNotHaveDuplicatedValues, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1069) CA1070 | Design | Info | DoNotDeclareEventFieldsAsVirtual, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1070) CA1200 | Documentation | Hidden | AvoidUsingCrefTagsWithAPrefixAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1200) -CA1300 | Globalization | Disabled | SpecifyMessageBoxOptionsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1300) -CA1301 | Globalization | Disabled | AvoidDuplicateAcceleratorsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1301) CA1303 | Globalization | Disabled | DoNotPassLiteralsAsLocalizedParameters, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1303) CA1304 | Globalization | Hidden | SpecifyCultureInfoAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1304) CA1305 | Globalization | Hidden | SpecifyIFormatProviderAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1305) -CA1306 | Globalization | Disabled | SetLocaleForDataTypesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1306) CA1307 | Globalization | Disabled | SpecifyStringComparisonAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1307) CA1308 | Globalization | Disabled | NormalizeStringsToUppercaseAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1308) CA1309 | Globalization | Hidden | UseOrdinalStringComparisonAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1309) CA1310 | Globalization | Hidden | SpecifyStringComparisonAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1310) CA1401 | Interoperability | Info | PInvokeDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1401) -CA1414 | Interoperability | Disabled | MarkBooleanPInvokeArgumentsWithMarshalAsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1414) CA1416 | Interoperability | Warning | PlatformCompatabilityAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1416) CA1417 | Interoperability | Warning | DoNotUseOutAttributeStringPInvokeParametersAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1417) -CA1500 | Maintainability | Disabled | VariableNamesShouldNotMatchFieldNamesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1500) CA1501 | Maintainability | Disabled | CodeMetricsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1501) CA1502 | Maintainability | Disabled | CodeMetricsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1502) CA1505 | Maintainability | Disabled | CodeMetricsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1505) @@ -75,7 +70,6 @@ CA1506 | Maintainability | Disabled | CodeMetricsAnalyzer, [Documentation](https CA1507 | Maintainability | Info | UseNameofInPlaceOfStringAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1507) CA1508 | Maintainability | Disabled | AvoidDeadConditionalCode, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1508) CA1509 | Maintainability | Disabled | CodeMetricsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1509) -CA1601 | Mobility | Disabled | DoNotUseTimersThatPreventPowerStateChangesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1601) CA1700 | Naming | Disabled | DoNotNameEnumValuesReserved, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1700) CA1707 | Naming | Hidden | IdentifiersShouldNotContainUnderscoresAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1707) CA1708 | Naming | Hidden | IdentifiersShouldDifferByMoreThanCaseAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1708) @@ -89,7 +83,6 @@ CA1720 | Naming | Hidden | IdentifiersShouldNotContainTypeNames, [Documentation] CA1721 | Naming | Disabled | PropertyNamesShouldNotMatchGetMethodsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1721) CA1724 | Naming | Disabled | TypeNamesShouldNotMatchNamespacesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1724) CA1725 | Naming | Hidden | ParameterNamesShouldMatchBaseDeclarationAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1725) -CA1726 | Naming | Disabled | UsePreferredTermsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1726) CA1801 | Usage | Disabled | ReviewUnusedParametersAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1801) CA1802 | Performance | Disabled | UseLiteralsWhereAppropriateAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1802) CA1805 | Performance | Info | DoNotInitializeUnnecessarilyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1805) @@ -121,7 +114,6 @@ CA1836 | Performance | Info | UseCountProperlyAnalyzer, [Documentation](https:// CA1837 | Performance | Info | UseEnvironmentProcessId, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1837) CA1838 | Performance | Hidden | AvoidStringBuilderPInvokeParametersAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1838) CA2000 | Reliability | Disabled | DisposeObjectsBeforeLosingScope, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2000) -CA2001 | Reliability | Disabled | AvoidCallingProblematicMethodsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2001) CA2002 | Reliability | Disabled | DoNotLockOnObjectsWithWeakIdentityAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2002) CA2007 | Reliability | Disabled | DoNotDirectlyAwaitATaskAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2007) CA2008 | Reliability | Disabled | DoNotCreateTasksWithoutPassingATaskSchedulerAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2008) @@ -139,11 +131,9 @@ CA2119 | Security | Disabled | SealMethodsThatSatisfyPrivateInterfacesAnalyzer, CA2153 | Security | Disabled | DoNotCatchCorruptedStateExceptionsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2153) CA2200 | Usage | Warning | RethrowToPreserveStackDetailsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2200) CA2201 | Usage | Hidden | DoNotRaiseReservedExceptionTypesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2201) -CA2205 | Usage | Disabled | UseManagedEquivalentsOfWin32ApiAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2205) CA2207 | Usage | Disabled | InitializeStaticFieldsInlineAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2207) CA2208 | Usage | Info | InstantiateArgumentExceptionsCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2208) CA2211 | Usage | Info | NonConstantFieldsShouldNotBeVisibleAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2211) -CA2212 | Usage | Disabled | DoNotMarkServicedComponentsWithWebMethodAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2212) CA2213 | Usage | Disabled | DisposableFieldsShouldBeDisposed, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2213) CA2214 | Usage | Disabled | DoNotCallOverridableMethodsInConstructorsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2214) CA2215 | Usage | Hidden | DisposeMethodsShouldCallBaseClassDispose, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2215) @@ -155,14 +145,9 @@ CA2226 | Usage | Disabled | OperatorsShouldHaveSymmetricalOverloadsAnalyzer, [Do CA2227 | Usage | Disabled | CollectionPropertiesShouldBeReadOnlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2227) CA2229 | Usage | Hidden | SerializationRulesDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2229) CA2231 | Usage | Info | OverloadOperatorEqualsOnOverridingValueTypeEqualsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2231) -CA2232 | Usage | Disabled | MarkWindowsFormsEntryPointsWithStaThreadAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2232) CA2234 | Usage | Disabled | PassSystemUriObjectsInsteadOfStringsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2234) CA2235 | Usage | Disabled | SerializationRulesDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2235) -CA2236 | Usage | Disabled | CallBaseClassMethodsOnISerializableTypesAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2236) CA2237 | Usage | Disabled | SerializationRulesDiagnosticAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2237) -CA2238 | Usage | Disabled | ImplementSerializationMethodsCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2238) -CA2239 | Usage | Disabled | ProvideDeserializationMethodsForOptionalFieldsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2239) -CA2240 | Usage | Disabled | ImplementISerializableCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2240) CA2241 | Usage | Info | ProvideCorrectArgumentsToFormattingMethodsAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2241) CA2242 | Usage | Info | TestForNaNCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2242) CA2243 | Usage | Disabled | AttributeStringLiteralsShouldParseCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca2243) diff --git a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UsePreferredTerms.cs b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UsePreferredTerms.cs index 3e61930699..9c054c76a0 100644 --- a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UsePreferredTerms.cs +++ b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/UsePreferredTerms.cs @@ -3,7 +3,6 @@ using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; -using Analyzer.Utilities; namespace Microsoft.CodeQuality.Analyzers.ApiDesignGuidelines { @@ -14,7 +13,7 @@ public abstract class UsePreferredTermsAnalyzer : DiagnosticAnalyzer { internal const string RuleId = "CA1726"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.UsePreferredTermsTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.UsePreferredTermsTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageAssembly = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.UsePreferredTermsMessageAssembly), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageNamespace = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.UsePreferredTermsMessageNamespace), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); @@ -177,7 +176,7 @@ public abstract class UsePreferredTermsAnalyzer : DiagnosticAnalyzer description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(AssemblyRule, NamespaceRule, MemberParameterRule, DelegateParameterRule, TypeTypeParameterRule, MethodTypeParameterRule, TypeRule, MemberRule, AssemblyNoAlternateRule, NamespaceNoAlternateRule, MemberParameterNoAlternateRule, DelegateParameterNoAlternateRule, TypeTypeParameterNoAlternateRule, MethodTypeParameterNoAlternateRule, TypeNoAlternateRule, MemberNoAlternateRule); diff --git a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiReview/AvoidCallingProblematicMethods.cs b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiReview/AvoidCallingProblematicMethods.cs index 3a9db9d2db..b2444b5084 100644 --- a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiReview/AvoidCallingProblematicMethods.cs +++ b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiReview/AvoidCallingProblematicMethods.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis.Diagnostics; using Microsoft.CodeAnalysis; @@ -14,7 +13,7 @@ public abstract class AvoidCallingProblematicMethodsAnalyzer : DiagnosticAnalyze { internal const string RuleId = "CA2001"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.AvoidCallingProblematicMethodsTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.AvoidCallingProblematicMethodsTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageSystemGCCollect = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.AvoidCallingProblematicMethodsMessageSystemGCCollect), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageSystemThreadingThreadResume = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.AvoidCallingProblematicMethodsMessageSystemThreadingThreadResume), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); @@ -117,7 +116,7 @@ public abstract class AvoidCallingProblematicMethodsAnalyzer : DiagnosticAnalyze description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; // ImmutableArray.Create(SystemGCCollectRule, SystemThreadingThreadResumeRule, SystemThreadingThreadSuspendRule, SystemTypeInvokeMemberRule, CoInitializeSecurityRule, CoSetProxyBlanketRule, SystemRuntimeInteropServicesSafeHandleDangerousGetHandleRule, SystemReflectionAssemblyLoadFromRule, SystemReflectionAssemblyLoadFileRule, SystemReflectionAssemblyLoadWithPartialNameRule); diff --git a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/VariableNamesShouldNotMatchFieldNames.cs b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/VariableNamesShouldNotMatchFieldNames.cs index 33a38b1ee0..39925b6ddf 100644 --- a/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/VariableNamesShouldNotMatchFieldNames.cs +++ b/src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/VariableNamesShouldNotMatchFieldNames.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class VariableNamesShouldNotMatchFieldNamesAnalyzer : Diagnostic { internal const string RuleId = "CA1500"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.VariableNamesShouldNotMatchFieldNamesTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.VariableNamesShouldNotMatchFieldNamesTitle), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageLocal = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.VariableNamesShouldNotMatchFieldNamesMessageLocal), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); private static readonly LocalizableString s_localizableMessageParameter = new LocalizableResourceString(nameof(MicrosoftCodeQualityAnalyzersResources.VariableNamesShouldNotMatchFieldNamesMessageParameter), MicrosoftCodeQualityAnalyzersResources.ResourceManager, typeof(MicrosoftCodeQualityAnalyzersResources)); @@ -37,7 +36,7 @@ public abstract class VariableNamesShouldNotMatchFieldNamesAnalyzer : Diagnostic description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(LocalRule, ParameterRule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/MarkBooleanPInvokeArgumentsWithMarshalAs.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/MarkBooleanPInvokeArgumentsWithMarshalAs.cs index 6dac107bbc..df36ca0298 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/MarkBooleanPInvokeArgumentsWithMarshalAs.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/MarkBooleanPInvokeArgumentsWithMarshalAs.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class MarkBooleanPInvokeArgumentsWithMarshalAsAnalyzer : Diagnos { internal const string RuleId = "CA1414"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.MarkBooleanPInvokeArgumentsWithMarshalAsTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.MarkBooleanPInvokeArgumentsWithMarshalAsTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageDefault = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.MarkBooleanPInvokeArgumentsWithMarshalAsMessageDefault), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageReturn = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.MarkBooleanPInvokeArgumentsWithMarshalAsMessageReturn), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -37,7 +36,7 @@ public abstract class MarkBooleanPInvokeArgumentsWithMarshalAsAnalyzer : Diagnos description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(DefaultRule, ReturnRule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseManagedEquivalentsOfWin32Api.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseManagedEquivalentsOfWin32Api.cs index c4d41fd035..a7698a555d 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseManagedEquivalentsOfWin32Api.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/InteropServices/UseManagedEquivalentsOfWin32Api.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis.Diagnostics; using Microsoft.CodeAnalysis; @@ -14,7 +13,7 @@ public abstract class UseManagedEquivalentsOfWin32ApiAnalyzer : DiagnosticAnalyz { internal const string RuleId = "CA2205"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.UseManagedEquivalentsOfWin32ApiTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.UseManagedEquivalentsOfWin32ApiTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.UseManagedEquivalentsOfWin32ApiMessage), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.UseManagedEquivalentsOfWin32ApiDescription), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class UseManagedEquivalentsOfWin32ApiAnalyzer : DiagnosticAnalyz description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseTimersThatPreventPowerStateChanges.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseTimersThatPreventPowerStateChanges.cs index 69cf10bec6..5f1a18df0b 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseTimersThatPreventPowerStateChanges.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseTimersThatPreventPowerStateChanges.cs @@ -3,7 +3,6 @@ using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; -using Analyzer.Utilities; namespace Microsoft.NetCore.Analyzers.Runtime { @@ -14,7 +13,7 @@ public abstract class DoNotUseTimersThatPreventPowerStateChangesAnalyzer : Diagn { internal const string RuleId = "CA1601"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.DoNotUseTimersThatPreventPowerStateChangesTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.DoNotUseTimersThatPreventPowerStateChangesTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.DoNotUseTimersThatPreventPowerStateChangesMessage), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.DoNotUseTimersThatPreventPowerStateChangesDescription), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class DoNotUseTimersThatPreventPowerStateChangesAnalyzer : Diagn description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementISerializableCorrectly.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementISerializableCorrectly.cs index 1f57c873c2..a099cea6e1 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementISerializableCorrectly.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementISerializableCorrectly.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class ImplementISerializableCorrectlyAnalyzer : DiagnosticAnalyz { internal const string RuleId = "CA2240"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementISerializableCorrectlyTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementISerializableCorrectlyTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageDefault = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementISerializableCorrectlyMessageDefault), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageMakeVisible = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementISerializableCorrectlyMessageMakeVisible), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -47,7 +46,7 @@ public abstract class ImplementISerializableCorrectlyAnalyzer : DiagnosticAnalyz description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //DiagnosticHelpers.EnabledByDefaultIfNotBuildingVSIX ? ImmutableArray.Create(DefaultRule, MakeVisibleRule, MakeOverridableRule) : ImmutableArray.Empty; diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementSerializationMethodsCorrectly.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementSerializationMethodsCorrectly.cs index 153956ba3a..85de4edf21 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementSerializationMethodsCorrectly.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ImplementSerializationMethodsCorrectly.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class ImplementSerializationMethodsCorrectlyAnalyzer : Diagnosti { internal const string RuleId = "CA2238"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementSerializationMethodsCorrectlyTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementSerializationMethodsCorrectlyTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageVisibility = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementSerializationMethodsCorrectlyMessageVisibility), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageReturnType = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ImplementSerializationMethodsCorrectlyMessageReturnType), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -67,7 +66,7 @@ public abstract class ImplementSerializationMethodsCorrectlyAnalyzer : Diagnosti description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //DiagnosticHelpers.EnabledByDefaultIfNotBuildingVSIX ? ImmutableArray.Create(VisibilityRule, ReturnTypeRule, ParametersRule, GenericRule, StaticRule) : ImmutableArray.Empty; diff --git a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ProvideDeserializationMethodsForOptionalFields.cs b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ProvideDeserializationMethodsForOptionalFields.cs index 2f0377346f..90294937c8 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ProvideDeserializationMethodsForOptionalFields.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ProvideDeserializationMethodsForOptionalFields.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class ProvideDeserializationMethodsForOptionalFieldsAnalyzer : D { internal const string RuleId = "CA2239"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ProvideDeserializationMethodsForOptionalFieldsTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ProvideDeserializationMethodsForOptionalFieldsTitle), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageOnDeserialized = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ProvideDeserializationMethodsForOptionalFieldsMessageOnDeserialized), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); private static readonly LocalizableString s_localizableMessageOnDeserializing = new LocalizableResourceString(nameof(MicrosoftNetCoreAnalyzersResources.ProvideDeserializationMethodsForOptionalFieldsMessageOnDeserializing), MicrosoftNetCoreAnalyzersResources.ResourceManager, typeof(MicrosoftNetCoreAnalyzersResources)); @@ -37,7 +36,7 @@ public abstract class ProvideDeserializationMethodsForOptionalFieldsAnalyzer : D description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(OnDeserializedRule, OnDeserializingRule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/AvoidDuplicateAccelerators.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/AvoidDuplicateAccelerators.cs index e4bcdcfe61..32ba54acc8 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/AvoidDuplicateAccelerators.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/AvoidDuplicateAccelerators.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class AvoidDuplicateAcceleratorsAnalyzer : DiagnosticAnalyzer { internal const string RuleId = "CA1301"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.AvoidDuplicateAcceleratorsTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.AvoidDuplicateAcceleratorsTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.AvoidDuplicateAcceleratorsMessage), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.AvoidDuplicateAcceleratorsDescription), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class AvoidDuplicateAcceleratorsAnalyzer : DiagnosticAnalyzer description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/CallBaseClassMethodsOnISerializableTypes.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/CallBaseClassMethodsOnISerializableTypes.cs index 83ac3d7dcb..4cc662a581 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/CallBaseClassMethodsOnISerializableTypes.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/CallBaseClassMethodsOnISerializableTypes.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class CallBaseClassMethodsOnISerializableTypesAnalyzer : Diagnos { internal const string RuleId = "CA2236"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.CallBaseClassMethodsOnISerializableTypesTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.CallBaseClassMethodsOnISerializableTypesTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.CallBaseClassMethodsOnISerializableTypesMessage), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.CallBaseClassMethodsOnISerializableTypesDescription), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class CallBaseClassMethodsOnISerializableTypesAnalyzer : Diagnos description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotMarkServicedComponentsWithWebMethod.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotMarkServicedComponentsWithWebMethod.cs index a69d2bc2a0..3cfcf59710 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotMarkServicedComponentsWithWebMethod.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotMarkServicedComponentsWithWebMethod.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class DoNotMarkServicedComponentsWithWebMethodAnalyzer : Diagnos { internal const string RuleId = "CA2212"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.DoNotMarkServicedComponentsWithWebMethodTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.DoNotMarkServicedComponentsWithWebMethodTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.DoNotMarkServicedComponentsWithWebMethodMessage), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.DoNotMarkServicedComponentsWithWebMethodDescription), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class DoNotMarkServicedComponentsWithWebMethodAnalyzer : Diagnos description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/MarkWindowsFormsEntryPointsWithStaThread.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/MarkWindowsFormsEntryPointsWithStaThread.cs index 7e13663e92..04d2299c9f 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/MarkWindowsFormsEntryPointsWithStaThread.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/MarkWindowsFormsEntryPointsWithStaThread.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class MarkWindowsFormsEntryPointsWithStaThreadAnalyzer : Diagnos { internal const string RuleId = "CA2232"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.MarkWindowsFormsEntryPointsWithStaThreadTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.MarkWindowsFormsEntryPointsWithStaThreadTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.MarkWindowsFormsEntryPointsWithStaThreadMessage), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.MarkWindowsFormsEntryPointsWithStaThreadDescription), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class MarkWindowsFormsEntryPointsWithStaThreadAnalyzer : Diagnos description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SetLocaleForDataTypes.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SetLocaleForDataTypes.cs index 23a8aa5853..f2b92a7cff 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SetLocaleForDataTypes.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SetLocaleForDataTypes.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class SetLocaleForDataTypesAnalyzer : DiagnosticAnalyzer { internal const string RuleId = "CA1306"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.SetLocaleForDataTypesTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.SetLocaleForDataTypesTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.SetLocaleForDataTypesMessage), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.SetLocaleForDataTypesDescription), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class SetLocaleForDataTypesAnalyzer : DiagnosticAnalyzer description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SpecifyMessageBoxOptions.cs b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SpecifyMessageBoxOptions.cs index a21334a132..5b36e686d0 100644 --- a/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SpecifyMessageBoxOptions.cs +++ b/src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/SpecifyMessageBoxOptions.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -12,7 +11,7 @@ namespace Microsoft.NetFramework.Analyzers /// public abstract class SpecifyMessageBoxOptionsAnalyzer : DiagnosticAnalyzer { - internal const string RuleId = "CA1300"; + /*internal const string RuleId = "CA1300"; private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(MicrosoftNetFrameworkAnalyzersResources.SpecifyMessageBoxOptionsTitle), MicrosoftNetFrameworkAnalyzersResources.ResourceManager, typeof(MicrosoftNetFrameworkAnalyzersResources)); @@ -27,7 +26,7 @@ public abstract class SpecifyMessageBoxOptionsAnalyzer : DiagnosticAnalyzer description: s_localizableDescription, isPortedFxCopRule: true, isDataflowRule: false, - isEnabledByDefaultInFxCopAnalyzers: false); + isEnabledByDefaultInFxCopAnalyzers: false);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(Rule); diff --git a/src/Text.Analyzers/Core/AnalyzerReleases.Unshipped.md b/src/Text.Analyzers/Core/AnalyzerReleases.Unshipped.md index d7a95d32c6..cdf4f1397e 100644 --- a/src/Text.Analyzers/Core/AnalyzerReleases.Unshipped.md +++ b/src/Text.Analyzers/Core/AnalyzerReleases.Unshipped.md @@ -1,6 +1 @@ ; Please do not edit this file manually, it should only be updated through code fix application. - -### New Rules -Rule ID | Category | Severity | Notes ---------|----------|----------|------- -CA1704 | Naming | Disabled | IdentifiersShouldBeSpelledCorrectlyAnalyzer, [Documentation](https://docs.microsoft.com/visualstudio/code-quality/ca1704-identifiers-should-be-spelled-correctly) \ No newline at end of file diff --git a/src/Text.Analyzers/Core/IdentifiersShouldBeSpelledCorrectly.cs b/src/Text.Analyzers/Core/IdentifiersShouldBeSpelledCorrectly.cs index 49f8738944..c7dc185e43 100644 --- a/src/Text.Analyzers/Core/IdentifiersShouldBeSpelledCorrectly.cs +++ b/src/Text.Analyzers/Core/IdentifiersShouldBeSpelledCorrectly.cs @@ -1,7 +1,6 @@ // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System.Collections.Immutable; -using Analyzer.Utilities; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -14,7 +13,7 @@ public abstract class IdentifiersShouldBeSpelledCorrectlyAnalyzer : DiagnosticAn { internal const string RuleId = "CA1704"; - private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyTitle), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources)); + /*private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyTitle), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources)); private static readonly LocalizableString s_localizableMessageAssembly = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyMessageAssembly), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources)); private static readonly LocalizableString s_localizableMessageNamespace = new LocalizableResourceString(nameof(TextAnalyzersResources.IdentifiersShouldBeSpelledCorrectlyMessageNamespace), TextAnalyzersResources.ResourceManager, typeof(TextAnalyzersResources)); @@ -177,7 +176,7 @@ public abstract class IdentifiersShouldBeSpelledCorrectlyAnalyzer : DiagnosticAn isEnabledByDefault: false, description: s_localizableDescription, helpLinkUri: "https://docs.microsoft.com/visualstudio/code-quality/ca1704", - customTags: FxCopWellKnownDiagnosticTags.PortedFxCopRule); + customTags: FxCopWellKnownDiagnosticTags.PortedFxCopRule);*/ public override ImmutableArray SupportedDiagnostics => ImmutableArray.Empty; //ImmutableArray.Create(AssemblyRule, NamespaceRule, TypeRule, MemberRule, MemberParameterRule, DelegateParameterRule, TypeTypeParameterRule, MethodTypeParameterRule, AssemblyMoreMeaningfulNameRule, NamespaceMoreMeaningfulNameRule, TypeMoreMeaningfulNameRule, MemberMoreMeaningfulNameRule, MemberParameterMoreMeaningfulNameRule, DelegateParameterMoreMeaningfulNameRule, TypeTypeParameterMoreMeaningfulNameRule, MethodTypeParameterMoreMeaningfulNameRule);