Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] callback-based API #1097

Closed
Absolucy opened this issue Jun 7, 2022 · 4 comments
Closed

[Request] callback-based API #1097

Absolucy opened this issue Jun 7, 2022 · 4 comments

Comments

@Absolucy
Copy link

Absolucy commented Jun 7, 2022

Hi, I've been making a userspace filesystem library for Rust (planning to wrap both FUSE and Dokany - with the FUSE half pretty much done already), and I noticed one problem that's stopping me from doing the dokany side - lack of async support. I'm using the low-level FUSE functions which have a "reply" callback, rather than synchronously using the return value from the function.

Is anything liked this planned or in the works for Dokany?

@Liryna
Copy link
Member

Liryna commented Jun 8, 2022

Hi @Absolucy ,

There is a pull request opened just for that actually #307
A large part of this pull request was merged. I am not planning to merge the remaining part (see my comment here) but I am open to pull request!

@Absolucy
Copy link
Author

Absolucy commented Jun 8, 2022

I wish I knew enough about the Dokan codebase to contribute.

I mean, I guess I could learn and try when I have some free time, but no guarantees.

Out of curiosity, why not merge that part of the PR? The comment doesn't seem to explain the "why".

@Liryna
Copy link
Member

Liryna commented Jun 8, 2022

The PR is a rewrite of the library with a lot of great ideas (memory pull / threading / ...) which are now merged and took a lot of effort to happen.
I did not merge the redesign of the new async API to avoid adding another layer of complexity while knowing there were still pending issues 1 2 and having an async API wasn't requested by the community since.

Since now the v2 library is stable as v1 was, it looks more realistic to have the new async API merged and have the known issues being fixed.

@Liryna
Copy link
Member

Liryna commented Jun 23, 2022

@Absolucy Let me know if you need more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants