Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle obsolete/overeager password rules #23

Open
dnet opened this issue Nov 8, 2022 · 1 comment
Open

Handle obsolete/overeager password rules #23

dnet opened this issue Nov 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dnet
Copy link
Owner

dnet commented Nov 8, 2022

Even if the user selects a certain subset of characters (such as uppercase letters), there's no guarantee that the password will actually contain at least n (usually 1) element from that subset. While not a security problem in itself, this presents a problem with obsolete/overeager password strength enforcement algorithms that expect to have n (usually 1, sometimes 2, etc.) character from each of their defined subset present within the password.

Screenshot of an example of such an obsolete password strength meter

Although in some cases the "generate a new password" feature can be used with some luck to overcome this, it's poor UX and not guaranteed to work. Since RWD is already XORed with a (currently random, c.f. #11) string of bits, these could be altered upon user request to ensure the password contains one instance of each of the selected subsets. KeePassXC for example implements such a control with a checkbox "Pick characters from every group".

@dnet dnet added the enhancement New feature or request label Nov 8, 2022
@stef
Copy link

stef commented Nov 8, 2022

sounds reasonable to reuse the xor mask for this indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants