Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(styles): replacing nav.css with tailwind #834

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

TylerGeorgeAlexander
Copy link
Contributor

This resolves #772

@ghost
Copy link

ghost commented Nov 8, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Copy link
Contributor

@jtfairbank jtfairbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using conventional comments:

  • praise: looks really great, loved learning about tailwind's peer modifier

  • issue: the main "Routes" nav item has lost it's hover highlight

@jtfairbank jtfairbank merged commit 3acddf6 into saga Nov 10, 2022
@jtfairbank jtfairbank deleted the ta-tailwindclasses branch November 10, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Custom CSS Classes in Stylesheets > Tailwind Classes
2 participants