-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical Error: cannot process multiple files at once #55
Comments
@GreenFlag31 Yeah, I know. You should checkout the original "node-canvas" issue. Also, your library adds no new functionality and is just a fork of this one? |
Currently "node-canvas" replaced with "@napi-rs/canvas". Please try v3.6.3 |
Hi, thanks for the update. Replacing a key dependency feels scary, however, I trust you did extensive testing with the replacement. I only did a quick, surface-level research, but @napi-rs/canvas seems like a perfect drop-in replacement. I found some worrying old issues, like missing support for some popular fonts, which I do not know if they are relevant to this library, or have perhaps even already been fixed. I will upgrade and report back my findings, once I have more time. |
Because transforming PDFs into PNGs (and then further PNG processing) is computationally expensive I do it inside Node.js worker_threads, so they do not block the main thread execution.
When I try launching two threads, each processing its own PDF file the following error is thrown, which kills the thread process:
Note:
rm -r node_modules
thennpm install
did not resolve the issueUpdate: I found out that the issue lies with the
canvas
dependency, which still does not support worker_threads: Automattic/node-canvas#1394The text was updated successfully, but these errors were encountered: