feat: Make the contract support any ERC-20 token #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would review it in a bit ser. Thank you |
Dprof-in-tech
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Did something totally different.
What you are meant to do was to make the Wallet contract to accept ERC20 tokens, but you wrote a totally different contract. Which isn’t what is needed.
So you should study the Wallet contracts and modify the functions that uses usdt to accept any erc20 token, then you should add new tests and modify existing tests to capture your changes.
|
@Dprof-in-tech okay, give me some time to study wallet contracts & do code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10