Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winrt backend currently reports rssi as TX power #196

Closed
rib opened this issue Aug 25, 2021 · 1 comment
Closed

winrt backend currently reports rssi as TX power #196

rib opened this issue Aug 25, 2021 · 1 comment
Assignees
@qdot
Labels
bug Something isn't working

Comments

@rib
Copy link
Contributor

rib commented Aug 25, 2021

Describe the bug
The winrt backend is reporting RawSignalStrengthInDBm as the tx_power_level instead of TransmitPowerLevelInDBm

Expected behavior
BluetoothLEAdvertisementReceivedEventArgs::TransmitPowerLevelInDBm should be reported instead

Incidentally it also looks like it would be good to support reporting rssi in btleplug in addition to tx power so it's possible to calculate/estimate the signal loss. (#76 raise this before but I think perhaps rssi was being considered as equivalent to tx power when the issue was closed?)
@rib rib added the bug Something isn't working label Aug 25, 2021
@rib rib assigned qdot Aug 25, 2021
rib added a commit to rib/btleplug that referenced this issue Aug 25, 2021
@rib
winrtble: Report TX power as tx_power_level instead of RSSI
b40ddab 
Previously the winrt backend was reporting the RSSI (receiver power)
as the TX (transmission power)

Fixes: deviceplug#196
@qwandor
Copy link
Collaborator

qwandor commented Aug 25, 2021

Fixed in dev by #197.

@qwandor qwandor closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qdot qdot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qdot @qwandor @rib