Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http header canonicalization modifying responses #23

Open
denandz opened this issue May 27, 2024 · 2 comments
Open

net/http header canonicalization modifying responses #23

denandz opened this issue May 27, 2024 · 2 comments

Comments

@denandz
Copy link
Owner

denandz commented May 27, 2024 •
edited
Loading

net/http implements transparent header canonicalization when reading to / writing from the headers object. Meaning if a server sends x-some-header, martian (and net/http) will transparently change that to X-Some-Header.

This breaks clients which are not RFC compliant and introduces traffic mutation for what should be a transparent intercepting proxy.
@denandz denandz mentioned this issue Jun 3, 2024
Open
@denandz
Copy link
Owner Author

denandz commented Jun 3, 2024

More information is available in the Go issue: golang/go#37834

@denandz
Copy link
Owner Author

denandz commented Aug 27, 2024

Partially addressed by commit 36a42ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denandz