Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash: fix tx rate handling #2251

Open
buck54321 opened this issue Mar 24, 2023 · 3 comments
Open

zcash: fix tx rate handling #2251

buck54321 opened this issue Mar 24, 2023 · 3 comments
Assignees

Comments

@buck54321
Copy link
Member

ZCash fee handling is wrong. ZCash currently uses a standard fee of . 0001 per tx. We're still using it as a rate per byte. We're also using medianFeesTheHardWay, which scans full blocks. This is going to be expensive until the spam attack is fixed. We should simplify it and use the constant. We'll have to assume different units in a number of places. For example, what we return from the fee_rate API or assign to Match.{FeeRateBase,FeeRateQuote} is expected to be a rate/size. I think for zcash we have to interpret it as a rate/tx and eventually a rate/(input_count + output_count) once https://github.com/zcash/zips/blob/main/zip-0317.rst is in.

@chappjc
Copy link
Member

chappjc commented Mar 24, 2023

Good desc, and reasonable way to handle it for now. But is this a dup of #2239?

@buck54321
Copy link
Member Author

Oh. I completely forgot I opened that.

@buck54321
Copy link
Member Author

Now handled in #2553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants