From 074ee79c97ccb5885e930d6873ea22821170ae3f Mon Sep 17 00:00:00 2001
From: Mobin Aydinfar <mobin@mobintestserver.ir>
Date: Mon, 21 Oct 2024 17:02:08 +0330
Subject: [PATCH] FIX: dinit-iostream: Remove useless else(s)

According to CODE-STYLE:

>   2.2. Omit "else" if the body of the associated "if" does not fall through (i.e. if it always
>        either returns or throws an exception).

Signed-off-by: Mobin Aydinfar <mobin@mobintestserver.ir>
---
 src/dinit-iostream.cc | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/dinit-iostream.cc b/src/dinit-iostream.cc
index 322cd6d1..930a26a1 100644
--- a/src/dinit-iostream.cc
+++ b/src/dinit-iostream.cc
@@ -67,13 +67,13 @@ ssize_t ostream::put(const char *msg, size_t count) noexcept
     if (count == 0) {
         return 0; // Null/Empty message
     }
-    else if (count > buf->get_size()) {
+    if (count > buf->get_size()) {
         bool r = flush_nx();
         if (!r) {
             // io_error was set by flush_nx() call
             return -1;
         }
-        else while (count > static_cast<size_t>(buf->get_free())) {
+        while (count > static_cast<size_t>(buf->get_free())) {
             int prev_freespace = buf->get_free();
             buf->append(msg, prev_freespace);
             msg += prev_freespace;
@@ -88,7 +88,7 @@ ssize_t ostream::put(const char *msg, size_t count) noexcept
         buf->append(msg, count);
         return output_count + count;
     }
-    else while (count > static_cast<size_t>(buf->get_free())) {
+    while (count > static_cast<size_t>(buf->get_free())) {
         // If we haven't enough storage for caputring the message Firstly we try to fill buffer as
         // much as possible and then write the buffer.
         int prev_freespace = buf->get_free();
@@ -104,7 +104,6 @@ ssize_t ostream::put(const char *msg, size_t count) noexcept
     }
 
     buf->append(msg, count);
-
     return output_count + count;
 }
 
@@ -236,7 +235,8 @@ bool ostream::flush_nx() noexcept
     if (!good()) {
         return -1;
     }
-    else while (buf->get_length() > 0) {
+
+    while (buf->get_length() > 0) {
         char *ptr = buf->get_ptr(0);
         unsigned len = buf->get_contiguous_length(ptr);
         ssize_t r = bp_sys::write(fd, ptr, len);
@@ -613,7 +613,7 @@ int istream::getc_nx() noexcept
             eof_state = true;
             return -1;
         }
-        else if (r < 0) {
+        if (r < 0) {
             io_error = errno;
             return -1;
         }