Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a class to shadow hosts #302

Closed
RLesur opened this issue Mar 7, 2021 · 4 comments · Fixed by #303
Closed

Add a class to shadow hosts #302

RLesur opened this issue Mar 7, 2021 · 4 comments · Fixed by #303

Comments

@RLesur
Copy link
Contributor

RLesur commented Mar 7, 2021

Hi David,

In order to resolve rstudio/pagedown#216, it would be a great help if the shadow host elements get a class name:

"\n<div id=\"", uid[2], "\"></div>",

I'll submit a PR.

@davidgohel
Copy link
Owner

Hi Romain

No problem, do you need a specific class value or any value is OK?

@tvroylandt @RLesur I think it's a good idea to have shadow dom support if possible. Meanwhile, you can use knitr::opts_chunk$set(ft.shadow = FALSE) that is there for pagedown support.

@RLesur
Copy link
Contributor Author

RLesur commented Mar 8, 2021

I wasn't aware of the ft.shadow option. Thanks a lot for the tip!

@tvroylandt
Copy link

Thanks David ! This is a really useful option !

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants