Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use please, I can't use #![deny(non_ascii_idents)] #18

Open
spikespaz opened this issue Oct 21, 2023 · 0 comments
Open

Don't use please, I can't use #![deny(non_ascii_idents)] #18

spikespaz opened this issue Oct 21, 2023 · 0 comments

Comments

@spikespaz
Copy link

Don't use please, I can't use #![deny(non_ascii_idents)].

I saw that you've done this so that the macro output doesn't leak, and that people can't use symbols which are considered implementation minutiae. That sort of thing should be documented, but don't forcefully make that decision for people. They can still expand the macro and copy and paste the symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant