Which style of hunk-header=syntax with color-only is preferable?

[ghost]

#437 (comment)

@dandavison asked me to achieve hunk-header=syntax with color-only, but there are two options to achieve.

1: without @@

It's easy but needs to change a test into complicated way. Also, I think it's less viewable.

2: with @@

I think this is preferred, easier to see.

But code will be messy in paint.rs. To implement this, need to avoid here.

delta/src/paint.rs

Lines 422 to 424 in c71e3f4

	if !text.is_empty() {
	text.remove(0);
	}

What I want to ask

In either way, I need to change code a bit complicated.

So, I'd like to decide which one to progress.

[ghost]

resolved here
#443

[dandavison]

Yes, I agree, I think it has to be (2). The reason I say "has to be" is that I think we want color-only to mean: if you remove the colors, then the remaining text is identical to git's output throughout the entire patch: including the diff itself, and the metadata lines. So all the weird stuff like --- and @@ has to remain unchanged in delta's output.

Do you agree that that is what color-only should mean, and do you agree that we are currently obeying that rule?

[ghost]

Do you agree that that is what color-only should mean, and do you agree that we are currently obeying that rule?

Yes, exactly! As you said, I'm obeying that rule.
I'm relieved to hear that, thank you.