Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gifs #748

Merged
merged 20 commits into from
Feb 26, 2025
Merged

Gifs #748

merged 20 commits into from
Feb 26, 2025

Conversation

kernelkind
Copy link
Member

closes: #191

addresses comments in #743

@kernelkind kernelkind requested a review from jb55 February 25, 2025 02:03
@jb55
Copy link
Contributor

jb55 commented Feb 25, 2025

GifStateMap should be owned by the Image cache

@kernelkind
Copy link
Member Author

GifStateMap should be owned by the Image cache

Oh right it's not UI state perse, it's just dependent on time

@kernelkind
use bincode
9466c10 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
update ehttp to 0.5.0
fa9e318 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
introduce UrlMimes
4cd80c1 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
use mime_guess
5791b0c 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
add SupportedMimeType
bf68eb3 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
rename ImageCache -> MediaCache
4f4a0fe 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
Use TexturedImage in MediaCache
594ea0b 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
render MediaCache method
32b3e21 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
move MediaCache rendering to render_media_cache call
7c2b477 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
support multiple media cache files
888a933 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
introduce Images
fc9e1ff 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
render Images method
75a352a 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
migrate to using Images instead of MediaCache directly
33fdf64 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
URL mime hosted completeness
9592452 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
handle UrlCache io
0461a98 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
introduce gif animation
3e79f92 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
handle gif state
d1c7a5a 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
integrate gifs
490dedf 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
use SupportedMimeType for media_upload
e5fc461 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
render gif in PostView
9d88ba1 
Signed-off-by: kernelkind <[email protected]>
@kernelkind
Copy link
Member Author

Addressed this:

GifStateMap should be owned by the Image cache

and rebased with master

@jb55
Copy link
Contributor

jb55 commented Feb 26, 2025

when I test this my logs get spammed with:

2025-02-26T20:19:50.639184Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.672096Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.705347Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.738761Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.772488Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.805600Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.839552Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.872533Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)
2025-02-26T20:19:50.906455Z ERROR notedeck::urls: failed ehttp for UrlMimes: https://www.strategy.com/hub: Connection Failed: Connect error: Connection refused (os error 61)

@jb55 jb55 merged commit a524bbd into damus-io:master Feb 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GIF Support
2 participants
@kernelkind @jb55