-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Post Processing Effects to the Language #19
Comments
There's a "flip" toggle inside PostProcessing.cpp, which I manually changed in my local copy. Not sure if it has any other ramifications, or if it was set to default to that for a good reason, but it didn't seem to cause any issue. |
I've added call to setFlip() when initialising ofxPostProcessing...
|
PixelatePass doesn't have a setResolution() method, as I would expect. Other FX have methods to get/set the parameters of the FX. |
Created a fork of ofxPostProcessing that allows the resolution of Pixelate filter to be changed via getter/setter and allows width/height of output to be set without having to reinitialise the ofxPostProcessing object. |
Created pull request in original ofxPostProcessing repo |
Just committed this: 4d439fa Added parameter to bloom (glow) post processing effect, which also required extra addition of setter methods to BloomPass and ConvolutionPass in ofxPostProcessing - best to use my fork of ofxPostProcessing |
so, the effects now supported are: Kaleidoscope
NoiseWarp
Pixelate
Bloom (glow)
Note each fx command has version without params for default values. |
When post processing effects are enabled the output quality is reduced. This is more noticeable when you have it enabled (as per default settings when loading) but not FX are enabled in the code. |
Had a suggestion to move the shaders out to data files and reference them from settings file. Will require a more abstracted way of loading shaders than ofxPostProcessing. |
Massively late to the party on this one, but the inlined commands are really good - being able to switch up on the fly is really really useful. Last time I used Cyril in a live setting I ended up having multiple copies running with different effects running, as everything was external. This is infinitely better. The others I use a lot are tilt-shift and the toon shader, I might see if I can patch those into my fork for now? |
This commit includes an attempt to add basic support for post processing FX to the language. Needs a lot of refactoring, and I think there's still a memory leak due to the post processing object being in the state object and not cleaned up correctly. I think need to introduce a global state singleton.
Not ready for release, but if you want to test build from this commit:
a8697e8
Added to the language:
This enables the Kaleidoscope effect, takes 1 argument which is the number of segments.
This enables the noise warp effect and takes 3 arguments: Speed, amplitude and frequency.
FX are on by default, Turn them on and off with
CMD + z
Also still need to look at why ofxPostProcessing inverts the output when enabled.
The text was updated successfully, but these errors were encountered: