Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split scanning into 'quick scan' and 'full scan' #107

Open
cygnet3 opened this issue Feb 14, 2025 · 0 comments
Open

Split scanning into 'quick scan' and 'full scan' #107

cygnet3 opened this issue Feb 14, 2025 · 0 comments

Comments

@cygnet3
Copy link
Owner

cygnet3 commented Feb 14, 2025

Right now when we initiate a scan, we are scanning both the inputs and the outputs. The inputs are scanned to find owned outputs that are being spent.

Scanning the outputs is pretty much always needed. Scanning the inputs however, is only needed on these occasions:

  1. After a sending transaction, check if the tx has been confirmed
  2. If you have another wallet that uses the same seed, and you spend an owned input using another wallet.
  3. If you reset the scan height, and deleted some of your transaction history

Situation (1) is very predictable, since we initiate this ourselves. To avoid (2) we should tell users not to recover their wallet on 2 separate devices. (3) is related to resync issues. We probably need to investigate this separately, but this should only occur very rarely.

This means, that the vast majority of the time users are only interested in scanning the outputs. To accommodate for this, I think we should have a 'quick scan' feature that only scans the outputs. This can have significant performance improvements, but has a complexity tradeoff. But I think this tradeoff is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant