Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does the length_in_words field in capabilities/usage mean? #12

Open
cubanismo opened this issue Aug 8, 2017 · 1 comment
Open

Comments

@cubanismo
Copy link
Owner

cubanismo commented Aug 8, 2017

While reviewing the current prototype implementation, @mvicomoya pointed out the way I'd used length_in_words was more consistent with a field called extra_words or something, since it excludes the length of the header structure. Now I'm unclear which is preferable: Should length_in_words include the header structure or not? If not, should we change the name?

@mvicomoya
Copy link

Actually, would it make sense to have two fields "header_length" and "body_length"?

Note that if two drivers (or the library itself) use different versions of the allocator, and by any chance we modified the header in between, the current implementation would fail the comparison.

I think having two fields would help to keep backwards and forwards compatibility in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants