-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: outdated link in PERFORMANCE.md #1052
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the hyperlink in the PERFORMANCE.md document that references an article on speeding up SHA256 on ARM architecture. The update removes a fragment identifier from the URL. No changes are made to any logic, error handling, or exported entities in the codebase. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
PERFORMANCE.md (1)
82-82
: Markdown Lint: Unordered List Indentation
Static analysis indicates that the bullet list item on this line is indented by 2 spaces instead of 0, which violates markdownlint MD007. Please adjust the indentation to match the expected style.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
82-82: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
PERFORMANCE.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
PERFORMANCE.md
82-82: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
🔇 Additional comments (1)
PERFORMANCE.md (1)
82-82
: Updated Hyperlink Without Fragment Identifier
The updated URL for the "Speedup SHA256 100x on ARM" article now correctly omits the outdated fragment identifier. This change aligns with the PR objective and ensures users are directed to the correct resource.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
82-82: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
Summary by CodeRabbit