Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cgroups from the shim crate #258

Closed
Mossaka opened this issue Apr 3, 2024 · 2 comments
Closed

Remove cgroups from the shim crate #258

Mossaka opened this issue Apr 3, 2024 · 2 comments
Labels
C-shim Containerd shim Stale

Comments

@Mossaka
Copy link
Member

Mossaka commented Apr 3, 2024 

          Frankly speaking (in longer term) I think we should not carry cgroups related code in the `shim` crate. shim crate supposed to be the foundation for building new shim runtimes for containers on all platforms, without carrying any implementation details.

Originally posted by @mxpv in #254 (comment)
@mxpv mxpv added the C-shim Containerd shim label Apr 3, 2024
@Mossaka Mossaka mentioned this issue Jun 5, 2024
Closed
@mxpv mxpv pinned this issue Jun 17, 2024
@mxpv mxpv changed the title extract cgroups out of the shim crate Remove cgroups from the shim crate Jun 17, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Jan 11, 2025
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-shim Containerd shim Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxpv @Mossaka