Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: getAccountData function populating coins which is never being used and creating null errors #17

Open
wal33d006 opened this issue Jun 3, 2021 · 0 comments · May be fixed by #18
Open

Comments

@wal33d006
Copy link

File: account_data_reviewer.dart

The response returned from URL ${wallet.networkInfo.lcdUrl}/auth/accounts/${wallet.bech32Address} doesn't have coins property which is why this code

final coins = (value['coins'] as List)
        .map((coinMap) => StdCoin.fromJson(coinMap))
        .toList();

gives a null error. Even if the coins are being returned, this list of coins is never used anywhere in the flow. I solved it at my local. Creating a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant