Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create algorithm from challenge form visibility #3671

Closed
chrisvanrun opened this issue Oct 31, 2024 · 6 comments · Fixed by #3841
Closed

Create algorithm from challenge form visibility #3671

chrisvanrun opened this issue Oct 31, 2024 · 6 comments · Fixed by #3841
Assignees

Comments

@chrisvanrun
Copy link
Contributor

Currently, it's only a small link in a help text. We could improve this by having a clear button on the form that links to the algorithm-creation-for-challenge form.

I've seen reports of multiple users confused by this.

@jmsmkn
Copy link
Member

jmsmkn commented Nov 7, 2024

We could also do this from the algorithm list page by getting the user to select an active phase that they are a participant for. People with the Add Algorithm permission would still need to be have the additional link to the existing Algorithm Create Page.

@chrisvanrun
Copy link
Contributor Author

We could also do this from the algorithm list page by getting the user to select an active phase that they are a participant for. People with the Add Algorithm permission would still need to be have the additional link to the existing Algorithm Create Page.

I had this same thought when looking over the shoulders of a workshop participant.

@amickan
Copy link
Contributor

amickan commented Nov 8, 2024

Agreed!

@jmsmkn jmsmkn self-assigned this Feb 18, 2025
@jmsmkn
Copy link
Member

jmsmkn commented Feb 19, 2025

This is the page we need to direct people to: http://algorithm-evaluation-1.gc.localhost:8000/evaluation/phase-1/algorithms/create/

This is hooked up to PhaseAlgorithmCreate.as_view(), name="phase-algorithm-create".

It handles warning people that they have an existing algorithm.

  • In SubmissionCreate the user should be presented with the option to go straight to that page rather than being presented with the form if no algorithm is present. They might need warning if an image is being updated and it's just not there. Done in Anne's PR.
  • A separate form needs to be in place to direct people to PhaseAlgorithmCreate for their active phases.

Sorry, something went wrong.

@amickan
Copy link
Contributor

amickan commented Feb 19, 2025

With the changes in the optional inputs PR, I think the button to create a new algorithm (or manage existing ones) is already more obvious actually, so not sure if we need a more elaborate solution like the one you're describing:

Image

@jmsmkn
Copy link
Member

jmsmkn commented Feb 19, 2025

Okay that's great, then only the selection from the Algorithm List page is needed.

jmsmkn added a commit that referenced this issue Feb 20, 2025
Users are presented with the phases that they have the
`"create_phase_submission"` which is currently public phases for the
participants group, or all phases for the admins group.

<img width="1169" alt="Screenshot 2025-02-19 at 17 11 18"
src="https://github.com/user-attachments/assets/577cd1e6-6c02-45aa-9087-c0bbf19873ae"
/>

The check on whether the phase is open is very complex and in a mixin
that cannot really be re-used here, so we just clean the phase to see if
it is open for non-admins. The full check is then done on the redirect
but the errors are not as nice.

<img width="1164" alt="Screenshot 2025-02-19 at 17 11 25"
src="https://github.com/user-attachments/assets/94ea5fbd-cf7c-4309-9814-462ab464a0ce"
/>

If the phase is open then the user will end up on the usual page.

<img width="1148" alt="Screenshot 2025-02-19 at 17 11 33"
src="https://github.com/user-attachments/assets/52461f4d-91bb-479f-9bec-c1a4603dfff1"
/>

Those with custom algorithm permissions will see the extra link.

<img width="1176" alt="Screenshot 2025-02-19 at 17 15 39"
src="https://github.com/user-attachments/assets/43b2048f-dd6b-46bb-a033-8b7feb8f499e"
/>

Closes #3671

---------

Co-authored-by: Anne Mickan <amickan1990@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants