Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#1091 #1098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix/#1091 #1098

wants to merge 1 commit into from

Conversation

mmeloni
Copy link
Contributor

@mmeloni mmeloni commented Jan 14, 2022 •
edited
Loading

This PR do the followings:

  • CLI now accepts absoute token file path.
  • If no abs path is provided cmd package use xdg.state_home path + immudb (folder)+ default . Immudb is agnostic of xdg
  • file file tokenservice tokenfile property now became TokenFileAbsPath
  • immuadmin accepts credentials on env vars

@mmeloni mmeloni force-pushed the fix/#1091 branch 2 times, most recently from 2ce1b7c to 61f475f Compare January 17, 2022 17:14
@mmeloni mmeloni linked an issue Jan 18, 2022 that may be closed by this pull request
immuadmin ignores --tokenfile #1091
Open
@coveralls
Copy link
Collaborator

coveralls commented Jan 18, 2022 •
edited
Loading

Coverage Status

Coverage: 89.208% (-0.007%) from 89.215% when pulling becc1c5 on fix/#1091 into be85a0e on master.

@mmeloni mmeloni force-pushed the fix/#1091 branch 2 times, most recently from 94e94f6 to 1b05178 Compare January 19, 2022 10:48
@mmeloni mmeloni linked an issue Jan 20, 2022 that may be closed by this pull request
Improve immudb tools scriptability #1093
Open
2 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

16.3% 16.3% Coverage
2.5% 2.5% Duplication

@mmeloni mmeloni requested a review from byo January 20, 2022 10:43
@mmeloni mmeloni marked this pull request as ready for review January 20, 2022 10:45
SimoneLazzaris
SimoneLazzaris previously approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@SimoneLazzaris SimoneLazzaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmeloni mmeloni mentioned this pull request Feb 14, 2022
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

16.3% 16.3% Coverage
2.5% 2.5% Duplication

@benfu-verses
Copy link

Any chance this can get merged? We are trying to automate the setup of immudb with immuadmin but it cannot connect to immudb non-interactively

@jeroiraz
Copy link
Contributor

Any chance this can get merged? We are trying to automate the setup of immudb with immuadmin but it cannot connect to immudb non-interactively

Hi @benfu-verses , I'll review it

@mmeloni @jeroiraz
WIP
becc1c5 
Signed-off-by: Michele Meloni <[email protected]>

fix(pkg/client/tokenservice): file cache accepts the absolute file path of token file

Signed-off-by: Michele Meloni <[email protected]>

fix(pkg/client/tokenservice): immuclient accepts absolute token file path

Signed-off-by: Michele Meloni <[email protected]>

chore: tokenfile is stored on home state folder

Signed-off-by: Michele Meloni <[email protected]>

chore(cmd): fix login tests

Signed-off-by: Michele Meloni <[email protected]>

chore(cmd/immuadmin/command): add credentials env vars

Signed-off-by: Michele Meloni <[email protected]>

fix(pkg/client/tokenservice): fix token handling on windows

Signed-off-by: Michele Meloni <[email protected]>

chore(cmd/immuclient): value only is disabled by default

Signed-off-by: Jeronimo Irazabal <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

17.4% 17.4% Coverage
3.1% 3.1% Duplication

@jeroiraz
Copy link
Contributor

@SimoneLazzaris, I resolved conflicts with current master branch. Could you please check immuadmin and immuclient are working as expected? thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimoneLazzaris SimoneLazzaris SimoneLazzaris left review comments

@byo byo Awaiting requested review from byo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve immudb tools scriptability immuadmin ignores --tokenfile
5 participants
@mmeloni @coveralls @benfu-verses @jeroiraz @SimoneLazzaris