From b6e870b55cb41b7e872efc8b3efa10fe58bd6be6 Mon Sep 17 00:00:00 2001 From: Deepak Mantena Date: Wed, 24 Feb 2021 12:28:12 -0800 Subject: [PATCH] Ignore warnings on imported `NYTPhotoViewer` and `FLAnimatedImage` dependencies. --- .../FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.m | 4 ++++ .../FLAnimatedImage/FLAnimatedImage/FLAnimatedImageView.m | 4 +++- .../Third Party Code/NYTPhotoViewer/NYTPhotoCaptionView.m | 3 +++ .../Third Party Code/NYTPhotoViewer/NYTPhotosViewController.m | 3 +++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.m b/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.m index 3fdddc969b6..402bb6faa5c 100755 --- a/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.m +++ b/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImage.m @@ -19,6 +19,9 @@ #define MEGABYTE (1024 * 1024) +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Weverything" + // This is how the fastest browsers do it as per 2012: http://nullsleep.tumblr.com/post/16524517190/animated-gif-minimum-frame-delay-browser-compatibility const NSTimeInterval kFLAnimatedImageDelayTimeIntervalMinimum = 0.02; @@ -814,3 +817,4 @@ - (NSMethodSignature *)methodSignatureForSelector:(SEL)selector @end +#pragma clang diagnostic pop diff --git a/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImageView.m b/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImageView.m index 26fea1d23e0..e6ce0015466 100755 --- a/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImageView.m +++ b/WMF Framework/Third Party/FLAnimatedImage/FLAnimatedImage/FLAnimatedImageView.m @@ -19,7 +19,8 @@ - (void)debug_animatedImageView:(FLAnimatedImageView *)animatedImageView waiting @end #endif - +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Weverything" @interface FLAnimatedImageView () // Override of public `readonly` properties as private `readwrite` @@ -440,3 +441,4 @@ - (void)displayLayer:(CALayer *)layer @end +#pragma clang diagnostic pop diff --git a/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotoCaptionView.m b/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotoCaptionView.m index 7f6c83b4b91..9e06dee5056 100644 --- a/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotoCaptionView.m +++ b/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotoCaptionView.m @@ -8,6 +8,8 @@ #import "NYTPhotoCaptionView.h" +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Weverything" static const CGFloat NYTPhotoCaptionViewHorizontalMargin = 8.0; static const CGFloat NYTPhotoCaptionViewVerticalMargin = 7.0; @@ -162,3 +164,4 @@ - (void)updateTextViewAttributedText { } @end +#pragma clang diagnostic pop diff --git a/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotosViewController.m b/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotosViewController.m index 7b573fa521e..4c016ae8880 100644 --- a/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotosViewController.m +++ b/Wikipedia/Third Party Code/NYTPhotoViewer/NYTPhotosViewController.m @@ -22,6 +22,8 @@ #import #endif +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wdeprecated" NSString * const NYTPhotosViewControllerDidNavigateToPhotoNotification = @"NYTPhotosViewControllerDidNavigateToPhotoNotification"; NSString * const NYTPhotosViewControllerWillDismissNotification = @"NYTPhotosViewControllerWillDismissNotification"; NSString * const NYTPhotosViewControllerDidDismissNotification = @"NYTPhotosViewControllerDidDismissNotification"; @@ -553,3 +555,4 @@ - (void)pageViewController:(UIPageViewController *)pageViewController didFinishA } @end +#pragma clang diagnostic pop