Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

send a message to the volunteer is the connection with the platform is succesful #30

Open
johnsmithm opened this issue Apr 12, 2020 · 3 comments

Comments

@johnsmithm
Copy link
Contributor

  • when the user share their number he/she get back a thank you message
  • it would be useful is the user know is the link to the platform is ok or not
  • if not, the user can contact the administration and ask to change the telegram-id or solve different problems if any
@ralienpp
Copy link
Collaborator

After the volunteer shares their number, we send them MSG_STANDBY = "Mulțumesc! Te vom alerta când apar cereri noi." as an acknowledgement.

If there is a problem on the server's side, then def link_chatid_to_volunteer(self, nickname, chat_id, phone) should return an error. Ideally, all the corrective actions should be taken by the software, automatically.

Keep in mind that the user is not aware of {platform, bot state, backend, link, MongoDB...}. Showing any messages like "We have successfully linked your telegram_chat_id to volunteer_id" or "Unfortunately your telegram_chat_id does not match your phone_id" is not going to do any good. These details should be hidden from users.

What actual problem prompted the creation of this issue? Can you describe situations in which the linking doesn't work? Let's focus on those, and find ways to resolve them without burdening the user or the administrator.

@johnsmithm
Copy link
Contributor Author

a situation when the linking does not work: the phone is wrong in the system, or the telegram id is not set at all in the platform, after the user have shared the phone and received the message "multumesc, etc", he thinks everything is ok and waits for the offer. If he receives a warning, the number is not in our database, contact the administrator please, I think will be better.

@ralienpp
Copy link
Collaborator

How about this: if the telegram_id is not found in the system, we send an alert to the admin (display pop-up in the front-end, send a private message to the bot's admin in Telegram, etc) and let them handle it. They can inspect the DB and fix the problem themselves, without getting the volunteer involved.

Worst case scenario - they'll contact the volunteer and ask for more details, if necessary.

The fundamental principle is that the problem should be delegated to those who are best equipped/qualified to deal with it.

The backend should only return 200 OK when it is really OK. If the backend already knows that things aren't OK - why should users inform the server about a problem the server is aware of?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants