Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Vertical misalignment of "Ctrl + K" icon inside the search bar #1703

Closed
VinaySatrasala opened this issue Jan 7, 2025 · 1 comment · Fixed by #1704
Closed

Bug: Vertical misalignment of "Ctrl + K" icon inside the search bar #1703

VinaySatrasala opened this issue Jan 7, 2025 · 1 comment · Fixed by #1704
Labels
bug Something isn't working

Comments

@VinaySatrasala
Copy link
Contributor

Describe the bug

The <kbd> element which shows icon inside search bar which says Ctrl + K is not aligned vertically.

To Reproduce

Steps to reproduce the behavior:

  1. Open the webpage or application where the <kbd> element is present.
  2. Inspect the <kbd> element using browser developer tools.
  3. Observe that the element is slightly offset from the vertical center of its container.

Expected behavior

The <kbd> element should be perfectly centered vertically within its parent container, ensuring a clean and consistent user interface.


Screenshots or GIFs

Before Fix:
image

After Fix:
image


Info (please complete the following information):

  • Browser: On any browser in windows machines
  • Version: Latest branch or release version where this issue occurs.

Additional context

The issue seems to stem from the use of hardcoded top-2.5 positioning without proper vertical centering adjustments. A simple fix involves replacing top-2.5 with top-1/2 and adding -translate-y-1/2.

This fix also ensures consistency across different themes (light and dark) and screen sizes.

@VinaySatrasala
Copy link
Contributor Author

Made a pull request #1704 which solves this issue please do review....!

devsargam added a commit that referenced this issue Jan 15, 2025
Bug-fix: Vertical misalignment of "Ctrl + K" icon inside the search bar #1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant