Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Adding Husky & Lint Staged #1670

Closed
avparadox opened this issue Dec 19, 2024 · 0 comments
Closed

feature: Adding Husky & Lint Staged #1670

avparadox opened this issue Dec 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@avparadox
Copy link
Contributor

avparadox commented Dec 19, 2024

A clear and concise description of what the problem is:

After making the changes, people don't follow the Prettier & Lint rules & then we face fails by GitHub Actions as mentioned below.

image

Describe the solution you'd like
Adding Husky & Lint Staged. Changing the package.json with Lint Staged array & then just hitting the lint-staged command during the final commit. If the person doesn't follow the lint rules, eslint & prettier will try to fix it or if failed then won't let the commit to be pushed. So fixing the lint becomes a must now.

image

image

Hey @devsargam do let me know if this would be helpful or it is fine to have lint errors & can be fixed later on.
Thank You for giving your time.

@avparadox avparadox added the enhancement New feature or request label Dec 19, 2024
@avparadox avparadox closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant