Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate GitLab code quality reports with Code PushUp issues #110

Open
3 tasks
matejchalk opened this issue Dec 20, 2024 · 0 comments
Open
3 tasks

Integrate GitLab code quality reports with Code PushUp issues #110

matejchalk opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request gitlab GitLab pipelines template (https://gitlab.com/code-pushup/gitlab-pipelines-template)

Comments

@matejchalk
Copy link
Contributor

User story

As a GitLab user, I would like to have some feature equivalent to GitHub annotations, so that during code review I can see new issues in source code which Code PushUp detected.

Research

GitLab CI/CD supports [Code Quality(https://docs.gitlab.com/ee/ci/testing/code_quality.html) reports, which are tightly integrated in the MR user interface.

Image

The Code Quality report format maps nicely to our Issue model. The only non-trivial field is the fingerprint, which serves to uniquely identify the violation. We could take inspiration from eslint-formatter-gitlab here, which hashes the relative file path, rule ID and message.

Acceptance criteria

  • the code-pushup.yml template creates a code quality report artifact
  • issues are converted to code quality report format with a unique fingerprint
  • if detectNewIssues is disabled, no such report is created
@matejchalk matejchalk added gitlab GitLab pipelines template (https://gitlab.com/code-pushup/gitlab-pipelines-template) enhancement New feature or request labels Dec 20, 2024
@matejchalk matejchalk mentioned this issue Dec 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitlab GitLab pipelines template (https://gitlab.com/code-pushup/gitlab-pipelines-template)
Projects
None yet
Development

No branches or pull requests

1 participant