Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping ESLint rules for unnecessary Promise wrap #29

Open
Tlacenka opened this issue Dec 31, 2024 · 0 comments
Open

Overlapping ESLint rules for unnecessary Promise wrap #29

Tlacenka opened this issue Dec 31, 2024 · 0 comments
Labels
➕ enhancement new feature or request

Comments

@Tlacenka
Copy link
Collaborator

User story

As an engineer, I want only one ESLint rule to target a given issue, so that I only get one finding per issue and avoid unnecessary noise.

Acceptance criteria

There is only one rule for reporting unnecessary Promise wrappers.

Minimal reproduction of current behaviour

The promise/no-return-wrap rule included from recommended config here .
The unicorn/no-useless-promise-resolve-reject rule included in recommended config here seems to be an expanded and auto-fixable version of that rule - it includes finally and yield constructs.

Desired behaviour showcase

The promise/no-return-wrap can be removed.

Which configuration is this related to?

default

ESLint version

No response

@Tlacenka Tlacenka added the ➕ enhancement new feature or request label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ enhancement new feature or request
Projects
None yet
Development

No branches or pull requests

1 participant