Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of documentation on minimum Node version #864

Open
michaelbromley opened this issue Nov 4, 2024 · 0 comments
Open

Lack of documentation on minimum Node version #864

michaelbromley opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
➕ enhancement new feature or request 📖 Project documentation improvements or additions to the project documentation

Comments

@michaelbromley
Copy link

What happened?

Hi!

I was running into the following error when testing out the CLI, after configuring the ESLint plugin:

npx code-pushup


TypeError: groups.toSorted is not a function
    at groupsFromRuleCategories  ....

I believe this stems from the use of the Array.prototype.toSorted() method, which is supported from Node v20+, whereas I was using Node v18.

What would you expect to happen?

There is no mention in the README about minimum node version, so it would be a good idea to add this as a pre-requisite in the "getting started" guide somewhere.

Even the GitHub Actions example config here: https://github.com/code-pushup/cli/wiki/Code-PushUp-integration-guide-for-Nx-monorepos#ci-automation is using Node v18 - so that should also be updated too.

What steps did you take?

As above - run npx code-pushup after following the getting started guide.

Code PushUp package version

"@code-pushup/cli": "^0.53.1", "@code-pushup/eslint-plugin": "^0.53.1",

What operation system are you on?

Linux

Node version

18.18.2

Relevant log output

TypeError: groups.toSorted is not a function
at groupsFromRuleCategories ....

@michaelbromley michaelbromley added the 🐛 bug something isn't working label Nov 4, 2024
@vmasek vmasek added ➕ enhancement new feature or request 📖 Project documentation improvements or additions to the project documentation and removed 🐛 bug something isn't working labels Nov 5, 2024
@vmasek vmasek self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ enhancement new feature or request 📖 Project documentation improvements or additions to the project documentation
Projects
None yet
Development

No branches or pull requests

2 participants