Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js Package Analyzer doesn't ignore exit code on yarn-modern package manager #836

Open
meljishi opened this issue Oct 11, 2024 · 2 comments
Labels
🐛 bug something isn't working

Comments

@meljishi
Copy link

What happened?

As commented on the slack channel, after using the javascript plugin with yarn v4 we couldn't make our runner work. The yarn audit command errors out when a dependency with a critical or high issue arises and the plugin doesn't ignore the exit code
Image

What would you expect to happen?

The plugin wrapper should only read the generated report and push it to the portal. Only should report an error when the process itselft crashes, not when the audit reports a critical issue.

What steps did you take?

Just run the analysis

Code PushUp package version

@code-pushup/[email protected]

What operation system are you on?

Linux

Node version

No response

Relevant log output

No response

@meljishi meljishi added the 🐛 bug something isn't working label Oct 11, 2024
@matejchalk
Copy link
Collaborator

@meljishi We shipped a fix for this a few weeks ago in version 0.55.0 (#878). Could you check if this resolves your issue?

@meljishi
Copy link
Author

meljishi commented Dec 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants