Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of "__test_target__" et al #1129

Open
melange396 opened this issue Apr 7, 2023 · 3 comments
Open

get rid of "__test_target__" et al #1129

melange396 opened this issue Apr 7, 2023 · 3 comments

Comments

@melange396
Copy link
Collaborator

many (if not all) of our integration and unit test files include the setting of a variable "__test_target__". it is also frequently accompanied by a comment of a form similar to "# py3tester coverage target (equivalent to `import *`)". they are no longer needed as we removed our dependence on py3tester a while ago. since then, we have even superstitiously perpetuated these code snippets in new test files created.

py3test references should also be yeeted from the following files:

.github/workflows/ci.yaml
deploy.json
dev/docker/python/setup.sh
dev/local/install.sh
dev/local/setup.cfg
docs/new_endpoint_tutorial.md
docs/epidata_development.md

this is a subset of what i mentioned in a comment on issue 965

@melange396
Copy link
Collaborator Author

an additional bonus to this would be that development docker images will be smaller and build faster!

@krivard
Copy link
Contributor

krivard commented Apr 7, 2023

does github-deploy-repo run py3tester or pytest?

if it runs pytest then we can slap help-wanted on this; if it runs py3tester that may require a bit more work

@dshemetov
Copy link
Contributor

dshemetov commented Apr 11, 2023

FWIW, I tried removing these before and ran into errors. I don't remember 100%, but I think the errors were only on staging, not in Docker unit/integration tests, which makes me think some part of github-deploy-repo still uses py3tester. See this thread for a recent failure due to this. We may have turned off py3tester there or maybe it was a TODO, not sure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants