temp: pin cloudflare provider version to 4

[DesmondH0]

Details

• A new cloudflare provider version had released around 14h ago which contains brunch of breaking changes
• We would need to pin the version to 4.X for keeping the module working before its ready to upgrade

Ref

• https://registry.terraform.io/providers/cloudflare/cloudflare/latest/docs/guides/version-5-upgrade

[RoseSecurity]

Thank you for raising this.

It's a tricky issue to navigate when it comes to breaking changes with providers, modules, and components. To maintain stability while waiting for module updates, Cloud Posse decided that the best course of action is to pin providers to major and minor versions in downstream components (e.g., ~> 4.0). This approach ensures compatibility while allowing patch updates without the rigidity of exact version pinning or the complexity of managing the .terraform.lock.hcl. Pinning in upstream modules was considered but would create compatibility issues when newer major versions are released.

[DesmondH0]

Thank you for raising this.

It's a tricky issue to navigate when it comes to breaking changes with providers, modules, and components. To maintain stability while waiting for module updates, Cloud Posse decided that the best course of action is to pin providers to major and minor versions in downstream components (e.g., ~> 4.0). This approach ensures compatibility while allowing patch updates without the rigidity of exact version pinning or the complexity of managing the .terraform.lock.hcl. Pinning in upstream modules was considered but would create compatibility issues when newer major versions are released.

Thanks, updated PR to pin latest minor version as well.

[RoseSecurity]

Sorry for the confusion. To clarify, Cloud Posse's general practice is to avoid pinning provider versions in upstream modules to ensure broader compatibility for the community. Instead, provider versions are pinned at the component level to major and minor versions (e.g., ~> 4.0) to maintain stability while allowing patch updates. You can find more details on this approach in this doc. For now, I am going to close this PR