Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate the default tags from aws provider #156

Closed
polak785 opened this issue Nov 2, 2023 · 1 comment
Closed

Propagate the default tags from aws provider #156

polak785 opened this issue Nov 2, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@polak785
Copy link

polak785 commented Nov 2, 2023

Describe the Feature

With ressources related to the AWS provider, we can set default tags as explain in https://www.hashicorp.com/blog/default-tags-in-the-terraform-aws-provider

Is this possible to your module to take them into account in order to propagate them to the ressources created ?

Otherwise it works with an explicit declaration tag :

module "nodegroup" {
  source  = "cloudposse/eks-node-group/aws"
...
  tags = merge(
    local.default_tags,
    { other = "value" }
)

Thus not a big deal but just wanted to know if you plan to add it automatically or I we need to explicit set them.

Thank you :)

Expected Behavior

Use the default tags declared in AWS provider, cf. https://www.hashicorp.com/blog/default-tags-in-the-terraform-aws-provider

Use Case

We use the default tag to propagate a tag that indicates from which git project and in which folder the ressource configuration comes from.

Describe Ideal Solution

Instead of explicit declared default tags to use in the module, use them automatically

Alternatives Considered

No response

Additional Context

No response

@settings settings bot removed the feature request label Apr 1, 2024
@Nuru Nuru added the invalid This doesn't seem right label Jun 10, 2024
@Nuru
Copy link
Contributor

Nuru commented Jun 10, 2024

This module does not create an Autoscaling Group (EKS does that automatically), and in all other cases the default tags are automatically propagated, so there is nothing for us to do here.

@Nuru Nuru closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants