-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring Auto Reconfiguration & Spring Cloud Connectors Deprecation Notice #951
Comments
FYI-- we've had a couple teams get bitten by the following:
We've advised them of how to fix the immediate issue (explicitly include |
Thanks @coffee-squirrel, you're 100% correct that I missed that change in the release notes. Apologies. I have updated the release notes to mention the feature change and to also bring more attention to the fact that the cloud profile needs to be manually enabled going forward. Hopefully that will help with folks performing the migration going forward. |
Just an update on this issue - we are extending the deprecation period until 2023/2024. This will give users more time to follow the migration guide and switch to Starting with the next release, Spring Auto Reconfiguration will be enabled by default as it was up to 4.51 and warnings will continue to be logged if the library is injected by the buildpack. The buildpack will default to disabling these features after the new date of March 2023 (explicit opt-in still possible), with the removal planned for a release after March 2024. |
Could we possibly enhance the documentation? Like a 1-to-1 comparison of old vs new with examples. Maybe a sample spring boot application to show what's changed. Not sure if I need to add that CfEnv bean and replace my vcap properties with cfEnv.findCredentialsByTag. A good example of how to make the docs better would be:
|
I haven't seen this in the release notes -- did this happen or has the date slipped? Is there a new target date? |
Hi, the v4.62.0 Release Notes state:
This conflicts with what was stated in this issue:
Is my understanding correct that the v4.62.0 buildpack release and its described deprecation timeline supersedes this one? |
We have a spring boot application (version 1.5.9.RELEASE) that is deployed in PCF and works fine. We are trying to migrate it to java-cfenv-boot library by following the migration guide and removing the dependencies it suggests. However, we encounter a problem with the centralized configuration. The application fails to get the placeholder values from the Spring Cloud Config Server (bound to PCF). removed added io.pivotal.cfenv java-cfenv-boot 2.4.0
and we use java_buildpack_offline Please suggest to fix the issue. |
hello @dev-praveen ! |
@anthonydahanne thanks for the reply below is manifest file and logs.applications:
2024-01-29T12:02:58.633+05:30 [APP/PROC/WEB/0] [OUT] org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'callbackServiceNavigator': Unsatisfied dependency expressed through field 'applicationThreadPoolExecutor'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'scopedTarget.springAsyncConfig': Injection of autowired dependencies failed; nested exception is java.lang.IllegalArgumentException: Could not resolve placeholder 'threadpool.corepool.size' in value "${threadpool.corepool.size}" |
Hi org.springframework.boot:spring-boot-starter-cloud-connectors dependencies from the project. Application couldn't able to locate the real config server and it is fall back to localhost with the above dependencies in the project belwo are the logs: 2024-01-25T12:52:52.305+05:30 [APP/PROC/WEB/0] [OUT] 2024-01-25 07:22:52.305 INFO 7 --- [ main] c.c.c.ConfigServicePropertySourceLocator : Fetching config from server at: https://config-server-11121121a-fdec-4ba5-c654-5ccff667744.apps.np.app.com 2024-01-25T12:52:54.122+05:30 [APP/PROC/WEB/0] [OUT] 2024-01-25 07:22:54.122 INFO 7 --- [ main] b.c.PropertySourceBootstrapConfiguration : Located property source: CompositePropertySource [name='configService', propertySources=[MapPropertySource {name='credhub-app-dev-master'}, MapPropertySource {name='credhub-app-dev-master'}, MapPropertySource {name='ssh://[email protected]:22/var/vcap/store/mirror/8475euhfjy348573857rjhgdfjh745647/davinci-config/davinci-app-dev.properties'}, MapPropertySource {name='ssh://[email protected]:22/var/vcap/store/mirror/8475euhfjy348573857rjhgdfjh745647/davinci-config/application.properties'}]] please help us why after removing recommended dependencies from the documentation application is not able to locate the real config server. |
I would like to request the community to extend the timeline for disabling the spring auto reconfiguration feature that comes with the java_buildpack_offline. |
Hi - the timeline described in this warning message seems a bit stale; can we confirm the latest plan? java-buildpack/lib/java_buildpack/framework/spring_auto_reconfiguration.rb Lines 96 to 100 in e2dd4eb
|
@nmck257 - true.
of course, those "auto" behaviors can be disabled via either |
that helps -- so to further clarify:
|
that's correct; we found out many users were not ready to have this default behavior removed.
No
Yes |
As was communicated on Slack, Github, and now with the latest Java Buildpack Release Notes (v4.49). Support for the Spring Auto Reconfiguration and Spring Cloud Connectors has been deprecated.
The buildpack will start by warning all users that have these features enabled. After Aug 2022, the buildpack will default to disabling these features and it will require users to explicitly opt into using them. After Dec 2022, all support for them will be removed.
The path forward is to use java-cfenv in your application. There CloudFoundry docs have instructions & migration information for users coming from Spring Cloud Connectors & Auto Reconfiguration.
This issue has been opened as an announcement and as a location for users to post feedback. Please feel free to post comments below or on Slack.
The text was updated successfully, but these errors were encountered: