Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM: incorrect dependency for @cloudflare/vitest-pool-workers #8082

Open
beanow-at-crabnebula opened this issue Feb 10, 2025 · 1 comment
Open
Labels
bug Something that isn't working needs reproduction Needs reproduction from OP vitest Relating to the Workers Vitest integration

Comments

@beanow-at-crabnebula
Copy link

@cloudflare/vitest-pool-workers depends on @vitest/runner/utils exporting a function getTestName.

This function was first exposed by vitest-dev/vitest#6716
And released in 2.1.4.

Meaning this peer dependency is incorrect:

"@vitest/runner": "2.0.x - 2.1.x",

As @vitest/runner/utils < 2.1.4 will fail with

The requested module '@vitest/runner/utils' does not provide an export named 'getTestName'

@edmundhung
Copy link
Member

Hi @beanow-at-crabnebula,

I don't see anywhere in our implementation where getTestName is imported. Is there any chance you're using a different version of vitest and the runner package? I've tested a hello world template with vitest v2.1.0 and haven't encountered any issues.

It would be really helpful if you could provide a reproduction. Thank you!

@emily-shen emily-shen added needs reproduction Needs reproduction from OP bug Something that isn't working vitest Relating to the Workers Vitest integration labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working needs reproduction Needs reproduction from OP vitest Relating to the Workers Vitest integration
Projects
Status: Untriaged
Development

No branches or pull requests

3 participants