Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters - Custom Filter Dialect/Custom Protocol #1323

Open
zZHorizonZz opened this issue Jan 5, 2025 · 0 comments
Open

Filters - Custom Filter Dialect/Custom Protocol #1323

zZHorizonZz opened this issue Jan 5, 2025 · 0 comments

Comments

@zZHorizonZz
Copy link

zZHorizonZz commented Jan 5, 2025

We're working on implementing the subscription API, but as we are going trough implementing this on our own as there aren't any language-specific implementations yet, we're a bit hesitant on some things. We're thinking that if language-specific implementations do appear in the future, there might be a problem if someone wants to use their own dialect.

Here's our reasoning: if someone generates their own server based on the OpenAPI specs, it'll generate the models for filters. But if they want to use a custom dialect, like CEL (Common Expression Language) in our case, they'd have to create a custom version of the subscription API specs and potentially provide custom SDKs instead of relying on official SDKs which we can imagine will contain the client or at least client abstraction for communication with subscription API.

We had similar thoughts about sink protocols. There's no way to provide a custom protocol right now. For example, if we wanted to use gRPC (with its own HTTP/2 protocol), we'd have to propose it and wait for it to be added to the official specification.

While we understand that the API specs aim to unify things, we think that implementors/providers should be able to decide on and provide their own filters and protocols.

I think for optional dialects there could be something like:

{ 
  "custom": {
    "type": "sql (Or any other dialect)"
    "expression": "source LIKE '%cloudevents%'"
  }
}
@zZHorizonZz zZHorizonZz changed the title Filters - Custom Filter Dialect Filters - Custom Filter Dialect/Custom Protocol Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant