Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INVITATIONS: Logged out clicks view without joining but doesn't see the button to join topic/group #1894

Closed
Tracked by #1949
ssin1901 opened this issue Feb 18, 2025 · 4 comments
Assignees
Labels
bug Something isn't working HOLD in pre-live Issues in pre-live that should *not* yet be released to production pre UX tests Wishlist for fixes before next UX test/s Story of Estonia Issues needing implementation before Story of Estonia launch UX Priority UX issues that are important to fix relatively soon

Comments

@ssin1901
Copy link

What is the problem?
Tested in Google Chrome in Developer app in Dev app

Logged out user clicks on View topic without joining (screenshot1) and is redirected to the topic but the button to join topic is missing (screenshot2)

Image

Image

Same for View group without joining (screenshot3, screenshot4)

Image

Image

Why is this a problem?
User is missing the prompt to join the topic in logged out view.

Possible solution.
Should be the same UX as for a logged in view (screenshot5)

Image

@ssin1901 ssin1901 added bug Something isn't working Story of Estonia Issues needing implementation before Story of Estonia launch labels Feb 18, 2025
@BeccaMelhuish BeccaMelhuish added pre UX tests Wishlist for fixes before next UX test/s UX Priority UX issues that are important to fix relatively soon labels Feb 18, 2025
@BeccaMelhuish
Copy link
Contributor

@DiverVM putting this straight to in progress and assigning you as it's linked to #1376
(@ssin1901 reminder to do it like that for such sub-issues, so they don't get left behind in no status :))

DiverVM added a commit that referenced this issue Feb 19, 2025
Chore: Enable buttons for logged out state [#1894]
@DiverVM DiverVM closed this as completed Feb 19, 2025
@github-project-automation github-project-automation bot moved this from Now - In Progress to In QA - development in Citizen OS GitHub issue priorities Feb 19, 2025
@DiverVM
Copy link
Collaborator

DiverVM commented Feb 19, 2025

fixed. One thing to mention here -> when logged out:

  • user clicks on join button
  • logs in through popup
  • appears on the same page, but not joined the topic/group automatically with login, user has to press button again.

This is due to some more complex fix we need to implement here, so let's have a separate issue here if needed

@ssin1901
Copy link
Author

@DiverVM thanks for mentioning the test steps! To me, all seems fixed except that the user has to press the button again when logged in (as you mentioned).

I'll make a separate issue but here is the screen recording @BeccaMelhuish

Screen.Recording.2025-02-19.at.12.18.17.mov

@BeccaMelhuish
Copy link
Contributor

Moving to ready for pre-live but mentioning this related issue still to be fixed: #1900

@BeccaMelhuish BeccaMelhuish moved this from In QA - development to Ready for pre-live in Citizen OS GitHub issue priorities Feb 19, 2025
@ilmartyrk ilmartyrk moved this from Ready for pre-live to In QA - pre-live in Citizen OS GitHub issue priorities Feb 19, 2025
@BeccaMelhuish BeccaMelhuish added the HOLD in pre-live Issues in pre-live that should *not* yet be released to production label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HOLD in pre-live Issues in pre-live that should *not* yet be released to production pre UX tests Wishlist for fixes before next UX test/s Story of Estonia Issues needing implementation before Story of Estonia launch UX Priority UX issues that are important to fix relatively soon
Projects
Status: In QA - pre-live
Development

No branches or pull requests

3 participants